Skip to content

Refactor recursion quotient helpers #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 31, 2025
Merged

Refactor recursion quotient helpers #160

merged 2 commits into from
Oct 31, 2025

Conversation

@sai-deng
Copy link
Contributor

@sai-deng sai-deng commented Oct 29, 2025

This is a preparation for #159

@sai-deng sai-deng self-assigned this Oct 29, 2025
@tcoratger tcoratger mentioned this pull request Oct 29, 2025
Merged
tcoratger
tcoratger reviewed Oct 29, 2025
View reviewed changes
4l0n50
4l0n50 reviewed Oct 31, 2025
View reviewed changes
Copy link
Contributor

@4l0n50 4l0n50 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you just moving recompose_quotient_from_chunks_circuit, compute_quotient_chunk_products, compute_quotient_evaluation, and vanishing_poly_at_point_circuit, and also wrapping the part of verify_circuit that computes the quotient polynomial evaluation from chunks into recompose_quotient_from_chunks_circuit?
I just want to confirm that I’m not missing any other significant changes. Otherwise, it looks good to me.

@sai-deng
Copy link
Contributor Author

sai-deng commented Oct 31, 2025

Are you just moving recompose_quotient_from_chunks_circuit, compute_quotient_chunk_products, compute_quotient_evaluation, and vanishing_poly_at_point_circuit, and also wrapping the part of verify_circuit that computes the quotient polynomial evaluation from chunks into recompose_quotient_from_chunks_circuit? I just want to confirm that I’m not missing any other significant changes. Otherwise, it looks good to me.

Yes. This PR is just moving codes.

@sai-deng sai-deng changed the title Refactor/refine recursion quotient helpers Refactor recursion quotient helpers Oct 31, 2025
@4l0n50 4l0n50 self-requested a review October 31, 2025 15:40
@github-project-automation github-project-automation bot moved this from Todo to Ready to be merged in Plonky3 Recursion Oct 31, 2025
@sai-deng sai-deng merged commit 4427531 into main Oct 31, 2025
8 checks passed
@sai-deng sai-deng deleted the sai/refactor_circuits_quotient branch October 31, 2025 15:55
@github-project-automation github-project-automation bot moved this from Ready to be merged to Done in Plonky3 Recursion Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tcoratger tcoratger tcoratger left review comments

@4l0n50 4l0n50 4l0n50 approved these changes

@hratoanina hratoanina Awaiting requested review from hratoanina

@LindaGuiga LindaGuiga Awaiting requested review from LindaGuiga

Assignees

@sai-deng sai-deng

Labels

None yet

Projects

Plonky3 Recursion
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sai-deng @4l0n50 @tcoratger