Microsoft Outlook - Find Email bug fix #18743
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
WalkthroughIncremented versions across multiple Microsoft Outlook actions and sources, updated package version, and modified find-email action logic to handle quoted $search and pagination. Updated app description to show quoted search examples. No other logic changes outside find-email. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor U as User/Tool Caller
participant A as Outlook Find Email Action
participant G as Microsoft Graph API
U->>A: Invoke find-email (search, filters, paging)
alt search provided
A->>A: ensureQuotes(search)
A->>G: GET /messages?$search="query"&$top=N
G-->>A: Messages[]
else no search
loop paginate until done
A->>G: GET /messages?$filter=...&$orderby=...&$top=N&$skip=...
G-->>A: Page of Messages[]
A->>A: accumulate emails
end
end
A-->>U: Collected emails + summary
note over A,U: Logic updated to always collect array results
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (22)
components/microsoft_outlook/actions/add-label-to-email/add-label-to-email.mjs(1 hunks)components/microsoft_outlook/actions/approve-workflow/approve-workflow.mjs(1 hunks)components/microsoft_outlook/actions/create-contact/create-contact.mjs(1 hunks)components/microsoft_outlook/actions/create-draft-email/create-draft-email.mjs(1 hunks)components/microsoft_outlook/actions/download-attachment/download-attachment.mjs(1 hunks)components/microsoft_outlook/actions/find-contacts/find-contacts.mjs(1 hunks)components/microsoft_outlook/actions/find-email/find-email.mjs(2 hunks)components/microsoft_outlook/actions/find-shared-folder-email/find-shared-folder-email.mjs(1 hunks)components/microsoft_outlook/actions/list-contacts/list-contacts.mjs(1 hunks)components/microsoft_outlook/actions/list-folders/list-folders.mjs(1 hunks)components/microsoft_outlook/actions/list-labels/list-labels.mjs(1 hunks)components/microsoft_outlook/actions/move-email-to-folder/move-email-to-folder.mjs(1 hunks)components/microsoft_outlook/actions/remove-label-from-email/remove-label-from-email.mjs(1 hunks)components/microsoft_outlook/actions/reply-to-email/reply-to-email.mjs(1 hunks)components/microsoft_outlook/actions/send-email/send-email.mjs(1 hunks)components/microsoft_outlook/actions/update-contact/update-contact.mjs(1 hunks)components/microsoft_outlook/microsoft_outlook.app.mjs(1 hunks)components/microsoft_outlook/package.json(1 hunks)components/microsoft_outlook/sources/new-attachment-received/new-attachment-received.mjs(1 hunks)components/microsoft_outlook/sources/new-contact/new-contact.mjs(1 hunks)components/microsoft_outlook/sources/new-email-in-shared-folder/new-email-in-shared-folder.mjs(1 hunks)components/microsoft_outlook/sources/new-email/new-email.mjs(1 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
components/microsoft_outlook/actions/find-email/find-email.mjs (1)
components/microsoft_outlook/actions/find-shared-folder-email/find-shared-folder-email.mjs (2)
emails(77-77)items(62-75)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Publish TypeScript components
- GitHub Check: Lint Code Base
- GitHub Check: Verify TypeScript components
🔇 Additional comments (18)
components/microsoft_outlook/actions/find-contacts/find-contacts.mjs (1)
6-6: LGTM!Version bump is appropriate for this coordinated release.
components/microsoft_outlook/sources/new-email/new-email.mjs (1)
10-10: LGTM!Version bump is appropriate for this coordinated release.
components/microsoft_outlook/actions/reply-to-email/reply-to-email.mjs (1)
7-7: LGTM!Version bump is appropriate for this coordinated release.
components/microsoft_outlook/actions/send-email/send-email.mjs (1)
7-7: LGTM!Version bump is appropriate for this coordinated release.
components/microsoft_outlook/actions/list-labels/list-labels.mjs (1)
7-7: LGTM!Version bump is appropriate for this coordinated release.
components/microsoft_outlook/sources/new-contact/new-contact.mjs (1)
8-8: LGTM!Version bump is appropriate for this coordinated release.
components/microsoft_outlook/actions/approve-workflow/approve-workflow.mjs (1)
7-7: LGTM!Version bump is appropriate for this coordinated release.
components/microsoft_outlook/actions/add-label-to-email/add-label-to-email.mjs (1)
8-8: LGTM!Version bump is appropriate for this coordinated release.
components/microsoft_outlook/actions/list-contacts/list-contacts.mjs (1)
6-6: LGTM! Version bump is appropriate.The version increment from 0.0.18 to 0.0.19 is consistent with the coordinated release across Microsoft Outlook components.
components/microsoft_outlook/microsoft_outlook.app.mjs (1)
241-241: Excellent clarification of the quote requirement.The updated description now explicitly shows that search queries must be wrapped in double quotes (e.g.,
"to:example@example.com","subject:example","pizza"). This directly addresses the issue where LLMs would omit quotes and cause errors when using the Microsoft Graph API search parameter.components/microsoft_outlook/actions/list-folders/list-folders.mjs (1)
7-7: LGTM! Version bump is appropriate.The version increment is consistent with the coordinated release across Microsoft Outlook components.
components/microsoft_outlook/actions/remove-label-from-email/remove-label-from-email.mjs (1)
7-7: LGTM! Version bump is appropriate.The version increment is consistent with the coordinated release across Microsoft Outlook components.
components/microsoft_outlook/sources/new-email-in-shared-folder/new-email-in-shared-folder.mjs (1)
9-9: LGTM! Version bump is appropriate.The version increment is consistent with the coordinated release across Microsoft Outlook components.
components/microsoft_outlook/actions/update-contact/update-contact.mjs (1)
6-6: LGTM! Version bump is appropriate.The version increment is consistent with the coordinated release across Microsoft Outlook components.
components/microsoft_outlook/actions/find-shared-folder-email/find-shared-folder-email.mjs (1)
7-7: LGTM! Version bump is appropriate.The version increment is consistent with the coordinated release. This action will also benefit from the updated search parameter description in the app file, which now clarifies the quote requirement.
components/microsoft_outlook/actions/move-email-to-folder/move-email-to-folder.mjs (1)
7-7: LGTM! Version bump is appropriate.The version increment is consistent with the coordinated release across Microsoft Outlook components.
components/microsoft_outlook/actions/find-email/find-email.mjs (2)
7-7: LGTM!Version bump is appropriate for this bug fix.
46-52: LGTM! The quote normalization handles the main use cases correctly.The
ensureQuotesmethod successfully addresses the PR objective by ensuring the search parameter is properly quoted for the Microsoft Graph API. The implementation correctly handles common cases like unquoted strings, single-quoted strings, and double-quoted strings.
1 participant
Resolves #18729
Summary by CodeRabbit
New Features
Documentation
Chores