-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Fixing redirect rules #16460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing redirect rules #16460
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Caution Review failedThe pull request is closed. WalkthroughThis update introduces a new documentation page for "Integrated Apps," providing an overview and a detailed listing of premium apps. The navigation metadata for the apps section is adjusted by renaming a property key. Several redirect rules in the Next.js configuration are removed or swapped, affecting legacy and nested path handling. Additionally, a glossary entry is updated to correct a hyperlink to the premium apps section, and a minor wording adjustment is made in the premium apps usage description. No changes are made to exported functions, variables, or the control flow of the application. Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs-v2/pages/apps/index.mdx (1)
13-16
: Premium Apps section is clearly labeled.The section provides a clear explanation of which apps require Premium Apps access.
Consider simplifying "in order to use" to just "to use" for better readability:
-The vast majority of integrated apps on Pipedream are free to use in your workflows across any plan. However, in order to use any of the below apps in an active workflow, your workspace will need to have access to [Premium Apps](https://pipedream.com/pricing): +The vast majority of integrated apps on Pipedream are free to use in your workflows across any plan. However, to use any of the below apps in an active workflow, your workspace will need to have access to [Premium Apps](https://pipedream.com/pricing):🧰 Tools
🪛 LanguageTool
[style] ~15-~15: Consider a shorter alternative to avoid wordiness.
Context: ...our workflows across any plan. However, in order to use any of the below apps in an active ...(IN_ORDER_TO_PREMIUM)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
docs-v2/next.config.mjs
(1 hunks)docs-v2/pages/apps/_meta.tsx
(1 hunks)docs-v2/pages/apps/index.mdx
(1 hunks)docs-v2/pages/glossary.mdx
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
docs-v2/pages/apps/index.mdx
[style] ~15-~15: Consider a shorter alternative to avoid wordiness.
Context: ...our workflows across any plan. However, in order to use any of the below apps in an active ...
(IN_ORDER_TO_PREMIUM)
[grammar] ~24-~24: This phrase is duplicated. You should probably use “Cisco Webex” only once.
Context: ...ps://pipedream.com/apps/bigcommerce) - Cisco Webex - [Cisco Webex (Custom App)](https://pipedream.com/app...
(PHRASE_REPETITION)
[duplication] ~38-~38: Possible typo: you repeated a word.
Context: ...https://pipedream.com/apps/intercom) - Jira - [Jira Service Desk](https://pipedream.com/app...
(ENGLISH_WORD_REPEAT_RULE)
[duplication] ~41-~41: Possible typo: you repeated a word.
Context: ...(https://pipedream.com/apps/klaviyo) - Linkedin - [Linkedin Ads](https://pipedream.com/apps/linkedi...
(ENGLISH_WORD_REPEAT_RULE)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Lint Code Base
- GitHub Check: validate-links
🔇 Additional comments (7)
docs-v2/pages/glossary.mdx (1)
335-335
: Link path updated correctly.The hyperlink for the "full list of premium apps" has been updated from
/apps/apps#premium-apps
to/apps/#premium-apps
, which aligns with the new documentation structure and the newly added "Integrated Apps" page.docs-v2/pages/apps/_meta.tsx (1)
2-2
: Property key renamed to match file structure.The property key has been changed from
"apps"
to"index"
while maintaining the same value"Integrated Apps"
. This change aligns with the new file structure where the apps overview is now in anindex.mdx
file.docs-v2/pages/apps/index.mdx (3)
1-12
: LGTM! Well-structured introduction to integrated apps.The introduction clearly explains what integrated apps are in Pipedream and outlines their benefits to users.
17-73
: Comprehensive premium apps listing.The alphabetically sorted list provides direct links to each premium app, making it easy for users to find and access the specific app information they need.
🧰 Tools
🪛 LanguageTool
[grammar] ~24-~24: This phrase is duplicated. You should probably use “Cisco Webex” only once.
Context: ...ps://pipedream.com/apps/bigcommerce) - Cisco Webex - [Cisco Webex (Custom App)](https://pipedream.com/app...(PHRASE_REPETITION)
[duplication] ~38-~38: Possible typo: you repeated a word.
Context: ...https://pipedream.com/apps/intercom) - Jira - [Jira Service Desk](https://pipedream.com/app...(ENGLISH_WORD_REPEAT_RULE)
[duplication] ~41-~41: Possible typo: you repeated a word.
Context: ...(https://pipedream.com/apps/klaviyo) - Linkedin - [Linkedin Ads](https://pipedream.com/apps/linkedi...(ENGLISH_WORD_REPEAT_RULE)
74-79
: Well-placed call to action.The callout for requesting missing integrations and the link to the full list of integrated apps provide helpful resources for users who might be looking for specific integrations.
docs-v2/next.config.mjs (2)
495-497
: Redirect rule source and destination swapped.The redirection rule has been updated to redirect from
/workflows/projects/
to/projects/
instead of the other way around, which aligns with the current URL structure.
500-502
: Redirect rule source and destination swapped for path wildcards.The redirection rule has been updated to redirect from
/workflows/projects/:path*/
to/projects/:path*/
instead of the other way around, which aligns with the current URL structure and ensures consistency with the previous rule.
WHY
Summary by CodeRabbit
New Features
Documentation
Refactor