Skip to content

Fixing redirect rules #16460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 27, 2025
Merged

Conversation

dannyroosevelt
Copy link
Collaborator

@dannyroosevelt dannyroosevelt commented Apr 27, 2025

WHY

Summary by CodeRabbit

  • New Features

    • Introduced a new "Integrated Apps" documentation page, highlighting built-in integrations, key benefits, and a list of premium apps with direct links.
  • Documentation

    • Updated glossary entry for "Premium apps" with a corrected link to the premium apps section.
    • Renamed a property key in the apps metadata for consistency.
    • Simplified wording in the "Premium Apps" section for clarity.
  • Refactor

    • Removed and adjusted several redirect rules for simplified and updated navigation paths.

Copy link

vercel bot commented Apr 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 27, 2025 3:38pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
pipedream-docs ⬜️ Ignored (Inspect) Apr 27, 2025 3:38pm
pipedream-docs-redirect-do-not-edit ⬜️ Ignored (Inspect) Apr 27, 2025 3:38pm

Copy link
Contributor

coderabbitai bot commented Apr 27, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This update introduces a new documentation page for "Integrated Apps," providing an overview and a detailed listing of premium apps. The navigation metadata for the apps section is adjusted by renaming a property key. Several redirect rules in the Next.js configuration are removed or swapped, affecting legacy and nested path handling. Additionally, a glossary entry is updated to correct a hyperlink to the premium apps section, and a minor wording adjustment is made in the premium apps usage description. No changes are made to exported functions, variables, or the control flow of the application.

Changes

File(s) Change Summary
docs-v2/next.config.mjs Removed multiple redirect rules for legacy and nested paths; swapped two redirect entries' patterns.
docs-v2/pages/apps/_meta.tsx Renamed exported object property key from "apps" to "index" for navigation metadata.
docs-v2/pages/apps/index.mdx Added a new documentation page: "Integrated Apps" overview and premium apps listing.
docs-v2/pages/glossary.mdx Updated hyperlink for "full list of premium apps" to correct the URL path.
docs-v2/pages/apps/apps.mdx Simplified wording in the "Premium Apps" section regarding workspace access requirements.

Poem

🐇
A hop and a skip, new docs on the way,
"Integrated Apps" now has its own display.
Redirects are trimmed, paths neat and tight,
Premium apps listed—oh, what a sight!
With links all corrected, the docs shine anew,
A rabbit’s delight in all that you do!
🌱


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 17568f7 and 003eb45.

📒 Files selected for processing (1)
  • docs-v2/pages/apps/apps.mdx (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
docs-v2/pages/apps/index.mdx (1)

13-16: Premium Apps section is clearly labeled.

The section provides a clear explanation of which apps require Premium Apps access.

Consider simplifying "in order to use" to just "to use" for better readability:

-The vast majority of integrated apps on Pipedream are free to use in your workflows across any plan. However, in order to use any of the below apps in an active workflow, your workspace will need to have access to [Premium Apps](https://pipedream.com/pricing):
+The vast majority of integrated apps on Pipedream are free to use in your workflows across any plan. However, to use any of the below apps in an active workflow, your workspace will need to have access to [Premium Apps](https://pipedream.com/pricing):
🧰 Tools
🪛 LanguageTool

[style] ~15-~15: Consider a shorter alternative to avoid wordiness.
Context: ...our workflows across any plan. However, in order to use any of the below apps in an active ...

(IN_ORDER_TO_PREMIUM)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1b10426 and 17568f7.

📒 Files selected for processing (4)
  • docs-v2/next.config.mjs (1 hunks)
  • docs-v2/pages/apps/_meta.tsx (1 hunks)
  • docs-v2/pages/apps/index.mdx (1 hunks)
  • docs-v2/pages/glossary.mdx (1 hunks)
🧰 Additional context used
🪛 LanguageTool
docs-v2/pages/apps/index.mdx

[style] ~15-~15: Consider a shorter alternative to avoid wordiness.
Context: ...our workflows across any plan. However, in order to use any of the below apps in an active ...

(IN_ORDER_TO_PREMIUM)


[grammar] ~24-~24: This phrase is duplicated. You should probably use “Cisco Webex” only once.
Context: ...ps://pipedream.com/apps/bigcommerce) - Cisco Webex - [Cisco Webex (Custom App)](https://pipedream.com/app...

(PHRASE_REPETITION)


[duplication] ~38-~38: Possible typo: you repeated a word.
Context: ...https://pipedream.com/apps/intercom) - Jira - [Jira Service Desk](https://pipedream.com/app...

(ENGLISH_WORD_REPEAT_RULE)


[duplication] ~41-~41: Possible typo: you repeated a word.
Context: ...(https://pipedream.com/apps/klaviyo) - Linkedin - [Linkedin Ads](https://pipedream.com/apps/linkedi...

(ENGLISH_WORD_REPEAT_RULE)

⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Lint Code Base
  • GitHub Check: validate-links
🔇 Additional comments (7)
docs-v2/pages/glossary.mdx (1)

335-335: Link path updated correctly.

The hyperlink for the "full list of premium apps" has been updated from /apps/apps#premium-apps to /apps/#premium-apps, which aligns with the new documentation structure and the newly added "Integrated Apps" page.

docs-v2/pages/apps/_meta.tsx (1)

2-2: Property key renamed to match file structure.

The property key has been changed from "apps" to "index" while maintaining the same value "Integrated Apps". This change aligns with the new file structure where the apps overview is now in an index.mdx file.

docs-v2/pages/apps/index.mdx (3)

1-12: LGTM! Well-structured introduction to integrated apps.

The introduction clearly explains what integrated apps are in Pipedream and outlines their benefits to users.


17-73: Comprehensive premium apps listing.

The alphabetically sorted list provides direct links to each premium app, making it easy for users to find and access the specific app information they need.

🧰 Tools
🪛 LanguageTool

[grammar] ~24-~24: This phrase is duplicated. You should probably use “Cisco Webex” only once.
Context: ...ps://pipedream.com/apps/bigcommerce) - Cisco Webex - [Cisco Webex (Custom App)](https://pipedream.com/app...

(PHRASE_REPETITION)


[duplication] ~38-~38: Possible typo: you repeated a word.
Context: ...https://pipedream.com/apps/intercom) - Jira - [Jira Service Desk](https://pipedream.com/app...

(ENGLISH_WORD_REPEAT_RULE)


[duplication] ~41-~41: Possible typo: you repeated a word.
Context: ...(https://pipedream.com/apps/klaviyo) - Linkedin - [Linkedin Ads](https://pipedream.com/apps/linkedi...

(ENGLISH_WORD_REPEAT_RULE)


74-79: Well-placed call to action.

The callout for requesting missing integrations and the link to the full list of integrated apps provide helpful resources for users who might be looking for specific integrations.

docs-v2/next.config.mjs (2)

495-497: Redirect rule source and destination swapped.

The redirection rule has been updated to redirect from /workflows/projects/ to /projects/ instead of the other way around, which aligns with the current URL structure.


500-502: Redirect rule source and destination swapped for path wildcards.

The redirection rule has been updated to redirect from /workflows/projects/:path*/ to /projects/:path*/ instead of the other way around, which aligns with the current URL structure and ensures consistency with the previous rule.

@dannyroosevelt dannyroosevelt merged commit 50d817c into master Apr 27, 2025
6 of 8 checks passed
@dannyroosevelt dannyroosevelt deleted the danny/docs-redirect-accesscontrols branch April 27, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant