Configure: make sure pointers fit in IVs #23275
Conversation
See Perl#18995 This commit just adds a simple test that IV is large enough to hold a pointer; something we claim is true, but didn't actually guarantee.
|
Looks reasonable to me. (watching |
I don't think that references to a GH ticket are appropriate for the first line of a commit message. The first line should say what the commit does. The purpose or benefit of the commit should be explained in the body of the message. References to GH issues or other resources should go toward the end of the commit message. |
|
On 5/12/25 21:34, James E Keenan wrote:
*jkeenan* left a comment (Perl/perl5#23275) <https://github.com/Perl/
perl5/pull/23275#issuecomment-2874771656>
See #18995 <#18995>
|* This set of changes does not require a perldelta entry. |
I don't think that references to a GH ticket are appropriate for the /
first/ line of a commit message. The first line should say what the
commit does. The purpose or benefit of the commit should be explained in
the body of the message. References to GH issues or other resources
should go toward the end of the commit message.
I may have misunderstood things here. If the Subject line in a ticket
becomes the first line in a commit message, then the line with the short
GH reference here is satisfactory. I regret my error.
|
|
This change maybe is incompatible with Linux Intel X32 perl builds, if Linux's Intel x32 arch was ever tested or supported by p5p. someone needs to confirm. |
|
I believe Perl expects to be able to store a pointer in an IV, so that things wouldn't work anyway. I just Configured using the 32 bit emulation ability of gcc, and it worked fine. config.h shows 4 bytes for each value. |
x32 has 32-bit pointers and 32-bit ints, so there's no compatibility problem vs x32
x32 is different to what you get from i386/-m32, it takes advantage of the x86_64 architectural improvements (more registers, IP relative addressing, etc) while keeping pointers at 32-bits to save memory (consider how much of the data perl keeps is pointers) |
|
Backported as Perl/metaconfig@9769383 |
See #18995