Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean-up, modernize, and add examples for
$|
and autoflush #23147New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: blead
Are you sure you want to change the base?
Clean-up, modernize, and add examples for
$|
and autoflush #23147Changes from 1 commit
5df2817
b911e24
3e2e382
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't exactly what the previous comment was saying. It is saying that the channel may be buffered or not, if it is not buffered already then autoflush won't have any effect but it still defaults to 0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was worded weird originally which is why I tried to clean it up. I'm not sure what the correct less-wordy verbiage should be?
"Warning: External to Perl, the system may buffer a channel. If the system is not buffering a channel, then setting autoflush will not have any effect." ??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think rather than a warning, this statement is meant to be informational: the
$|
/autoflush setting always defaults to 0, and only indicates whether Perl flushes after each write, it does not indicate whether the channel is buffered by the system thus requiring flushing.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps it would be better to have this information in the same place where it discusses the usual buffering of
STDOUT
since this is the property it's describing and not the autoflush behavior itself. And add thatSTDERR
is typically unbuffered (but this may be system dependent, I am only familiar with Linux behavior).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also I was not being precise in saying autoflush won't have any effect on an unbuffered stream; Perl will still flush the handle after each write, it just won't make a difference because it wasn't being buffered anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The more I re-read this the more I think it was just informational. Personally I didn't think about the system buffering a channel, so knowing that setting autoflush in Perl may not always do what you want seems appropriate to me.
I think my wording here is ok-ish?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current wording in the commit is not useful information. The only reason to turn on autoflush is because the channel may be buffered.