Storable: use utf8_to_bytes_overwrite() if available #22956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is simpler and saves a malloc each time. Note that this code could use plain utf8_to_bytes() on older perls, but it is less convenient, so would require more code; I don't think the performance gain is worth it.
khwilliamson
force-pushed
the
more_to_fro_bytes
branch
from
ef6ed33 to
ac88e7f
Compare
tonycoz
reviewed
Feb 2, 2025
|
|
||
| /* If we are able to downgrade here; that means that we have a | ||
| * key which only had chars 0-255, but was utf8 encoded. */ | ||
| if (utf8_to_bytes_overwrite( (U8**) &keyval, &keylen_tmp)) { |
There was a problem hiding this comment.
I was a bit worried about this, since this modifies the PV belonging to a SV, but the SV is a copy of the key from the hash on this branch, so it's safe.
It does make a UTF-8 SV with a validly encoded PV into a UTF-8 SV with a probably invalidly encoded PV, but that SV is almost immediately discarded.
Will the new utf8_to_bytes_* functions be added to ppport.h?
There was a problem hiding this comment.
@khwilliamson could you respond to @tonycoz's concerns above? Thx.
tonycoz
approved these changes
Feb 3, 2025
khwilliamson
added
the
defer-next-dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is simpler and saves a malloc each time.
Note that this code could use plain utf8_to_bytes() on older perls, but it is less convenient, so would require more code; I don't think the performance gain is worth it.