-
Notifications
You must be signed in to change notification settings - Fork 211
Fix reference formatting in KAK demo #1395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hey, looks like you've updated some demos! 🐘 Don't forget to update the Please hide this comment once the field(s) are updated. Thanks! |
Thank you for opening this pull request. You can find the built site at this link. Deployment Info:
Note: It may take several minutes for updates to this pull request to be reflected on the deployed site. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be consistent, we should also add links to the other journal papers
the second reference to QSD I think it would be more consistent to have the whole journal reference as the link, not just Vol and No
In other demos we often link arxiv as arXiv:1234.1234 which I personaly prefer and think looks cleaner than writing "arXiv preprint" before each identifier-link
Co-authored-by: Korbinian Kottmann <43949391+Qottmann@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry to be a nuisance 😅 just looked at it and found the full stops a bit awkward. Looking through some demos, I dont think there is a gold standard, so leaving the suggestion (to be applied for all) as optional
I used nested formatting in reference links in #1372.
ReST does not support this.
Here we remove the nested formatting (and adjust two small wordings that struck me as suboptimal upon re-reading)