Skip to content

Fix reference formatting in KAK demo #1395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 3, 2025
Merged

Fix reference formatting in KAK demo #1395

merged 7 commits into from
Jun 3, 2025

Conversation

dwierichs
Copy link
Contributor

I used nested formatting in reference links in #1372.
ReST does not support this.
Here we remove the nested formatting (and adjust two small wordings that struck me as suboptimal upon re-reading)

Copy link

github-actions bot commented Jun 3, 2025

👋 Hey, looks like you've updated some demos!

🐘 Don't forget to update the dateOfLastModification in the associated metadata files so your changes are reflected in Glass Onion (search and recommendations).

Please hide this comment once the field(s) are updated. Thanks!

@dwierichs dwierichs requested review from cognigami and Qottmann June 3, 2025 07:30
Copy link

github-actions bot commented Jun 3, 2025

Thank you for opening this pull request.

You can find the built site at this link.

Deployment Info:

  • Pull Request ID: 1395
  • Deployment SHA: 642a1fc28726cadbc194af68f63129b1439dc70e
    (The Deployment SHA refers to the latest commit hash the docs were built from)

Note: It may take several minutes for updates to this pull request to be reflected on the deployed site.

Copy link
Collaborator

@Qottmann Qottmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be consistent, we should also add links to the other journal papers

the second reference to QSD I think it would be more consistent to have the whole journal reference as the link, not just Vol and No

In other demos we often link arxiv as arXiv:1234.1234 which I personaly prefer and think looks cleaner than writing "arXiv preprint" before each identifier-link

dwierichs and others added 2 commits June 3, 2025 10:17
Co-authored-by: Korbinian Kottmann <43949391+Qottmann@users.noreply.github.com>
Copy link
Collaborator

@Qottmann Qottmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to be a nuisance 😅 just looked at it and found the full stops a bit awkward. Looking through some demos, I dont think there is a gold standard, so leaving the suggestion (to be applied for all) as optional

@dwierichs dwierichs enabled auto-merge (squash) June 3, 2025 15:06
@dwierichs dwierichs merged commit 6858eeb into master Jun 3, 2025
7 of 8 checks passed
@dwierichs dwierichs deleted the fix-kak branch June 3, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants