[WIP] QDET demo #1327
[WIP] QDET demo #1327
Conversation
|
👋 Hey, looks like you've updated some demos! 🐘 Don't forget to update the Please hide this comment once the field(s) are updated. Thanks! |
|
Thank you for opening this pull request. You can find the built site at this link. Deployment Info:
Note: It may take several minutes for updates to this pull request to be reflected on the deployed site. |
There was a problem hiding this comment.
The tutorial is overall in good shape, but I left comments addressing mostly clarity of explanation.
More generally, the tutorial reads quite "dry" and uninspiring. A bit too late to correct that, but important to keep in mind for the future, that we are incentivized to create content that is more attractive and exciting
| # trev_pdep: 0.00001 # convergence threshold for eigenvalues | ||
| # | ||
| # wfreq_control: | ||
| # wfreq_calculation: XWGQH # compute quasiparticle corrections and Hamiltonian params |
There was a problem hiding this comment.
What in the world does XWGQH stand for?
There was a problem hiding this comment.
This is the weird keyword that WEST uses, here these alphabets specify what calculations are being performed.
A different combination is needed based on the application of interest, it is kind of random, X is for HF correction, H is for Hamiltonian, XWGQ as whole is for computing the quasiparticle corrections.
These are kind of random so seems weird explaining it.
| # macropol_calculation: C # include long-wavelength limit for condensed systems | ||
| # l_enable_off_diagonal: true # calculate off-diagonal elements of G_0-W_0 self-energy | ||
| # n_pdep_eigen_to_use: 512 # number of PDEP eigenvectors to be used | ||
| # qp_bands: [87,122,123,126,127,128] # impurity orbitals |
There was a problem hiding this comment.
This makes me think that it would be good to print them out explicitly from above
There was a problem hiding this comment.
Do you mean the impurity orbitals?
| # | ||
| # effective_hamiltonian = QDETResult(filename='west.wfreq.save/wfreq.json') | ||
| # | ||
| # The effective Hamiltonian can be solved using a high level method such as the full configuration |
There was a problem hiding this comment.
This is questionable for us, since the whole point is to use these effective Hamiltonians for quantum computing
There was a problem hiding this comment.
Added a line here about how this is not scalable to problems with larger impurities, therefore, we need quantum computing to solve systems that need larger impurities.
| # .. code-block:: python | ||
| # | ||
| # h_sparse = qml.SparseHamiltonian(qubit_op.sparse_matrix(), wires = qubit_op.wires) | ||
| # eigval_qubit = qml.eigvals(h_sparse) | ||
| # | ||
| # You can compare the results and verify that the computed energies match those that we obtained | ||
| # before. |
There was a problem hiding this comment.
I don't like this, it's saying that we don't need a quantum simulation since we can just compute the eigenvalues. Instead just print the Hamiltonian! I am actually curious to see what it looks like, and to verify that it is a proper PennyLane object
There was a problem hiding this comment.
The qubit Hamiltonian object is huge, so printing that might be too much here. I have changed the writing a bit to avoid this narrative.
Co-authored-by: ixfoduap <40441298+ixfoduap@users.noreply.github.com>
Co-authored-by: ixfoduap <40441298+ixfoduap@users.noreply.github.com>
Co-authored-by: ixfoduap <40441298+ixfoduap@users.noreply.github.com>
Co-authored-by: ixfoduap <40441298+ixfoduap@users.noreply.github.com>
Co-authored-by: ixfoduap <40441298+ixfoduap@users.noreply.github.com>
Co-authored-by: ixfoduap <40441298+ixfoduap@users.noreply.github.com>
Co-authored-by: ixfoduap <40441298+ixfoduap@users.noreply.github.com>
Co-authored-by: ixfoduap <40441298+ixfoduap@users.noreply.github.com>
Co-authored-by: ixfoduap <40441298+ixfoduap@users.noreply.github.com>
Co-authored-by: ixfoduap <40441298+ixfoduap@users.noreply.github.com>
Co-authored-by: ixfoduap <40441298+ixfoduap@users.noreply.github.com>
Co-authored-by: ixfoduap <40441298+ixfoduap@users.noreply.github.com>
Co-authored-by: ixfoduap <40441298+ixfoduap@users.noreply.github.com>
Before submitting
Please complete the following checklist when submitting a PR:
Ensure that your tutorial executes correctly, and conforms to the
guidelines specified in the README.
Remember to do a grammar check of the content you include.
All tutorials conform to
PEP8 standards.
To auto format files, simply
pip install black, and thenrun
black -l 100 path/to/file.py.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Title:
Summary:
Relevant references:
Possible Drawbacks:
Related GitHub Issues:
If you are writing a demonstration, please answer these questions to facilitate the marketing process.
GOALS — Why are we working on this now?
Eg. Promote a new PL feature or show a PL implementation of a recent paper.
AUDIENCE — Who is this for?
Eg. Chemistry researchers, PL educators, beginners in quantum computing.
KEYWORDS — What words should be included in the marketing post?
Which of the following types of documentation is most similar to your file?
(more details here)