-
Notifications
You must be signed in to change notification settings - Fork 47
Update pattern rewrite tutorial's code listing to use matchAndRewrite
#1783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello. You may have forgotten to update the changelog!
|
@dime10 Please delete the branch Also please delete the branches The only branch that is supposed to exist is the |
This PR doesn't update references to those branches, have they already been updated where appropriate? |
…write-tut-code-link
Yes, this link is updated:
This is the full code we link to for the merge-chained-unitary-gates pass we use as an example in the pattern rewrite tutorial: https://docs.pennylane.ai/projects/catalyst/en/stable/dev/transforms.html#invoking-transformation-patterns:~:text=point%20is%20reached.-,Note,described%20in%20this%20section%3A%20https%3A//github.com/PennyLaneAI/catalyst/commit/9afcc3500e12e5a51b78dda76cd4d27bdf4c8905,-Writing%20more%20general Currently this link points to the commit on branch The new link points to the The branches |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Paul!
I'm going to leave this branch until the new version is available as "stable" in the docs (i.e. next release). I deleted the other ones though. |
…write-tut-code-link
Co-authored-by: David Ittah <dime10@users.noreply.github.com>
Context:
In the latest llvm update, the individual
match
andrewrite
methods were removed.We update pattern rewrite tutorial's code listing to use
matchAndRewrite
.Benefits:
Code listing on tutorial is correct.