Skip to content

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Aug 7, 2025

Closes #942.

Changes proposed in this pull request

  • Modify merge_dwis so it works if b0_mean is NaN or correction is.

@tsalo tsalo added the bug Something isn't working label Aug 7, 2025
@tsalo tsalo requested review from mattcieslak and smeisler August 7, 2025 17:05
@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 46.17%. Comparing base (6d5b1e9) to head (2c56a9c).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
qsiprep/interfaces/dwi_merge.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #968   +/-   ##
=======================================
  Coverage   46.17%   46.17%           
=======================================
  Files          65       65           
  Lines        9745     9745           
  Branches     1069     1069           
=======================================
  Hits         4500     4500           
  Misses       5022     5022           
  Partials      223      223           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@mattcieslak mattcieslak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@mattcieslak mattcieslak merged commit b4099f1 into master Aug 7, 2025
24 checks passed
@mattcieslak mattcieslak deleted the fix-merge-dwis branch August 7, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[merge_dwis] harmonize_b0s: correction==nan; input formula couldn't be processed

3 participants