Skip to content

Fixed bug in Contributor Guidelines page #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

divine7022
Copy link
Contributor

@dlebauer
Fixes in Contributor Guidelines Page

Resolved Issues:

  • Fixed the "How to apply?" link, which previously redirected to a "Page Not Found" error.
  • Updated the Slack link, which was previously not linked.
  • Maintained the correct structure of the page for better readability.

Let me know if you want any improvements!
Thank you!

@dlebauer
Copy link
Member

is this duplicated by #96?

@divine7022
Copy link
Contributor Author

is this duplicated by #96?

@dlebauer Thanks a lot for your review sir!
This PR(#95) is not same as #96 . Theis PR address the following bug fixes in the given below image:
image
Resolved Issues:
Fixed the "How to apply?" link, which previously redirected to a "Page Not Found" error.
Updated the Slack link, which was previously not linked.
Maintained the correct structure of the page for better readability.

@dlebauer
Copy link
Member

@divine7022 this PR contains the same changes in src/pages/gsoc.js lines 31, 52, 58 in src/pages/gsoc.js as in #96. Perhaps you didn't intend to commit this file in this PR?

@divine7022
Copy link
Contributor Author

@divine7022 this PR contains the same changes in src/pages/gsoc.js lines 31, 52, 58 in src/pages/gsoc.js as in #96. Perhaps you didn't intend to commit this file in this PR?

@dlebauer
My apologies, it was unintentional to commit the changes from #96 . It happened by mistake.
Thanks for pointing it out!.

@divine7022
Copy link
Contributor Author

@dlebauer Hello sir!
Just to clarify, should I delete the file (src/pages/gsoc.js) from PR #96?

@dlebauer
Copy link
Member

Just to clarify, should I delete the file (src/pages/gsoc.js) from PR #96?

In this case since it is so small it probably won't matter. Worst case is that we can take care of it if a merge conflict arises.

But bigger picture, it is useful to make sure that you keep commits to a single branch so that the changes don't get duplicated - in some cases it can get tricky and confusing to sort out.

@dlebauer dlebauer merged commit 0a2974a into PecanProject:master Feb 26, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants