Skip to content

[WIP] Add Search Bar to Navbar to Improve User Experience #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

divine7022
Copy link
Contributor

Fixed: #90

This pull request adds a search bar to the navbar, improving the user experience by allowing quick access to site content via search. This addresses the need for enhanced navigation outlined in #90

Before:
image

After:
image

Screenshot 2025-02-18 065528

@divine7022
Copy link
Contributor Author

@dlebauer let me know if any further modifications are needed.

@dlebauer
Copy link
Member

Hi @divine7022 thanks for this contribution. Lets continue the discussion in #90

@dlebauer
Copy link
Member

@divine7022 could you please resolve conflicts in yarn.lock?

@divine7022
Copy link
Contributor Author

divine7022 commented Mar 28, 2025

Thanks for noticing! I'll review and resolve the conflicts soon.

@allgandalf allgandalf changed the title Add Search Bar to Navbar to Improve User Experience [WIP] Add Search Bar to Navbar to Improve User Experience Apr 26, 2025
@divine7022
Copy link
Contributor Author

divine7022 commented May 5, 2025

@dlebauer @allgandalf
Hello Sir,
I’ve fixed the indexing issue of the develop branch. Could you please merge it?
This merge is solely for testing purposes to verify if indexing works correctly with the production domain, which I couldn’t confirm on localhost.

Once if it worked, I’ll proceed to implement debouncing and address a few other things need to be fixed for the search functionality.

Thanks!

Copy link
Member

@dlebauer dlebauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@divine7022 thanks for resolving the conflicts.

Are these API keys supposed to be checked in, or should they be stored as github secrets?

@divine7022
Copy link
Contributor Author

Thanks for your feedback!

The current key in use is a search-only Algolia API key, which is safe for frontend usage. However, to follow best practices and keep the repository clean, could you please add apiKey to the repository’s gh secrets? And appId might change while testing if required; so, since the appId is less sensitive, i think we can commit appId for time being.

Name: ALGOLIA_API_KEY
05b54936b63721c91805e55ec170ae6b

Once it’s added, I’ll update the workflow to reference this secret accordingly.

@infotroph
Copy link
Member

  1. This is a public discussion, so everything posted here is no longer a secret.
  2. It looks like you're adding keys for a service that we decided in Enhance Site Navigation: Add Search Bar to Navbar #90 not to use. Was there followup discussion elsewhere that changed that decision?

@divine7022
Copy link
Contributor Author

Thanks for your feedback!

There hasn’t been any other discussion apart from #90
I explored a few open source alternatives for implementing search, but most of them are better suited for static site content. Since our documentation is served from another repository, those didn’t work as expected after try using them.

That’s why I revisited the Algolia based approach and fixed the issue occurring with the indexes of the develop branch. I thought we could move forward with this if debouncing worked.

Please let me know if you have any other preferences.

@divine7022
Copy link
Contributor Author

as an another option, since bookdown already provides a basic search for docs by default, could we stick with open source temporarily ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance Site Navigation: Add Search Bar to Navbar
3 participants