-
Notifications
You must be signed in to change notification settings - Fork 16
[WIP] Add Search Bar to Navbar to Improve User Experience #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@dlebauer let me know if any further modifications are needed. |
Hi @divine7022 thanks for this contribution. Lets continue the discussion in #90 |
@divine7022 could you please resolve conflicts in yarn.lock? |
Thanks for noticing! I'll review and resolve the conflicts soon. |
@dlebauer @allgandalf Once if it worked, I’ll proceed to implement debouncing and address a few other things need to be fixed for the search functionality. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@divine7022 thanks for resolving the conflicts.
Are these API keys supposed to be checked in, or should they be stored as github secrets?
Thanks for your feedback! The current key in use is a search-only Algolia API key, which is safe for frontend usage. However, to follow best practices and keep the repository clean, could you please add Name: ALGOLIA_API_KEY Once it’s added, I’ll update the workflow to reference this secret accordingly. |
|
Thanks for your feedback! There hasn’t been any other discussion apart from #90 That’s why I revisited the Algolia based approach and fixed the issue occurring with the indexes of the develop branch. I thought we could move forward with this if debouncing worked. Please let me know if you have any other preferences. |
as an another option, since |
Fixed: #90
This pull request adds a search bar to the navbar, improving the user experience by allowing quick access to site content via search. This addresses the need for enhanced navigation outlined in #90
Before:

After:
