Skip to content

Improve Footer UI: Added Icons & Arrows for Better Navigation #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 25, 2025

Conversation

divine7022
Copy link
Contributor

Fixed issue: #86

This PR enhances the footer section by improving visual clarity and navigation. The following changes were made:

  • Added icons and arrows to the footer links for better user experience.
  • Ensured consistent styling.
  • Improved text visibility and alignment to match the overall design.
  • Updated CSS to support both light and dark mode.

Before:

Screenshot 2025-02-17 012007

After:

Light mode -
image

Dark mode -
image

@divine7022
Copy link
Contributor Author

@dlebauer Let me know if there are any further modifications. Looking forward to your feedback.

@dlebauer
Copy link
Member

Hi @divine7022 thanks for submitting these changes! Definitely an improvement.

But now that I look more closely at the footer, I see that the fourth (rightmost) column is not needed. Could you please drop it and then realign the others?

@divine7022
Copy link
Contributor Author

@dlebauer Just to clarify, should I completely remove the 'Past Contributors' column and adjust the footer

@divine7022
Copy link
Contributor Author

@dlebauer Removed the fourth column & added a clickable PEcAn logo in the footer.

  • Removed the fourth (rightmost) column in the footer.
  • Added the PEcAn logo in the footer for better UI.
  • Made the logo clickable, redirecting to the home page when clicked.
    Click here to review the code.

Before:
image

After:
Ligntmode:
image
Darkmode:
image

Let me know if any further modifications are needed.
Thankyou

Copy link
Member

@dlebauer dlebauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks!

@divine7022
Copy link
Contributor Author

looks great, thanks!

@dlebauer My pleasure! Glad you liked it

@divine7022
Copy link
Contributor Author

@dlebauer ,
Hi sir, I noticed that all checks have passed on this PR and the review is complete. Is there anything blocking it from being merged?

@dlebauer dlebauer merged commit 2ddb060 into PecanProject:master Feb 25, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants