Move build display stats to its own file #8337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regisle
force-pushed
the
BuildDisplayStats
branch
from
7a5d8d6 to
8425953
Compare
LocalIdentity
approved these changes
Oct 20, 2024
LocalIdentity
merged commit c1904df
into
PathOfBuildingCommunity:dev
1 of 2 checks passed
benjaminysmall
added a commit
to benjaminysmall/PathOfBuilding
that referenced
this pull request
Jun 11, 2025
* FIX: Autoexertion not triggering supported skills (PathOfBuildingCommunity#8026) * Fix Autoexertion not applying Mana reservation to Warcries (PathOfBuildingCommunity#8029) I can't think of a better way to handle this Co-authored-by: LocalIdentity <localidentity2@gmail.com> * Fix Overexertion and Echoes of Creation counting non-exerting Warcries (PathOfBuildingCommunity#8027) * Fix Overexertion and Echoes of Creation including non-exerting Warcries The code was counting the total number of active Warcries instead of the total number of Exerting Warcries This PR also removed some redundant code that was used for old Call to Arms shared Warcry cooldowns Also cleans up some unneeded use of globals * Fix Overexertion variable name --------- Co-authored-by: LocalIdentity <localidentity2@gmail.com> * Fix Poison stacks not being capped by skills and config option (PathOfBuildingCommunity#8035) Updates the breakdowns and makes the single poison config work again Co-authored-by: LocalIdentity <localidentity2@gmail.com> * Fixes Rupture using the wrong stat for damage taken and Bleed duration (PathOfBuildingCommunity#8030) * damage_taken and expire_rate were inversed, resulting in wrong effective dps modifier * fix for incorrect "quicker bleedd" from rupture * forgot to change rupture duration type to match the calculation * Update CalcOffence.lua * Fix Export --------- Co-authored-by: LocalIdentity <31035929+LocalIdentity@users.noreply.github.com> Co-authored-by: LocalIdentity <localidentity2@gmail.com> * Fix quality check condition for item types (PathOfBuildingCommunity#8032) Corrected the logical error in the if condition to correctly check for specific item types such as Amulet, Belt, Jewel, Quiver, and Ring before setting item quality to nil. This ensures that NormaliseQuality() is able to properly set the default value. * Release 2.47.3 (PathOfBuildingCommunity#8036) * Prepare release 2.47.3 * Fix Changelogs --------- Co-authored-by: LocalIdentity <LocalIdentity@users.noreply.github.com> Co-authored-by: LocalIdentity <localidentity2@gmail.com> * Release 2.47.3 --- Fixed Crashes --- * Fix crash when importing builds to Party tab (Regisle) * Fix crash when using Svalin unique shield (Paliak) --- Fixed Calculations --- * Fix Inspiration granting more Mana cost instead of Less (LocalIdentity) * Fix Warcry trigger rate calculations (Paliak) * Fix Overexertion and Echoes of Creation counting non-exerting Warcries (LocalIdentity) * Fixes Rupture using the wrong stat for damage taken and Bleed duration (dreais) --- Fixed Behaviours --- * Fix Autoexertion not triggering supported skills (Paliak) * Fix Autoexertion not applying Mana reservation to Warcries (LocalIdentity) * Fix Poison stacks not being capped by skills and config option (LocalIdentity) * Fix item quality not defaulting to 20% (ConnorThelin) * indent space -> tab (PathOfBuildingCommunity#8058) * Svalin -> Svalinn (PathOfBuildingCommunity#8057) * Fix incorrect skillId for elder staff power charge on crit (PathOfBuildingCommunity#8048) * Fix charge duration not using More/Less modifiers (PathOfBuildingCommunity#8049) * check for empty build file (PathOfBuildingCommunity#8074) * add missing undostate when selecting skills with keyboard (PathOfBuildingCommunity#8072) Co-authored-by: nofate121 <nofate121@abc.def> * fix: ynda ward conversion mod not taking catalysts into consideration (PathOfBuildingCommunity#8062) * ModCache Regen * Merge loops Didn't need to have it loop through the skill list twice. Can just set both multipliers in one loop * FIX: the light of meaning applying to sockets (PathOfBuildingCommunity#8108) * FIX: wording for elemental damage on Combat Focus (PathOfBuildingCommunity#8111) * Fix parsing missing for new working on emberwake (PathOfBuildingCommunity#8110) * FIX: emberwake mod parsing. "up to" ignite count mod. * FIX: use lua patterns to avoid adding a new mod line * update Sap of the Seasons to add new cap (PathOfBuildingCommunity#8112) * Scale Warcry buffs by Warcry Power earlier in Calc (PathOfBuildingCommunity#8109) * Scale Warcry buffs by WarcryPower earlier in Calc * Remove Move speed precision --------- Co-authored-by: LocalIdentity <localidentity2@gmail.com> * Fix Rage Effect incorrectly scaling some mods (PathOfBuildingCommunity#8113) Mods that say `per x rage` do not scale with Rage effect Also updates Rigwald's Command with the new wording Co-authored-by: LocalIdentity <localidentity2@gmail.com> * Fix Arcane Surge effect per Summoned Totem mod not working (PathOfBuildingCommunity#8102) The calculation for active totems was done far later than the calc for ArcaneSurgeEffect causing it to not apply I believe moving this code should't cause any issues Co-authored-by: LocalIdentity <localidentity2@gmail.com> * FIX: full dps visual bug on gem dropdown (PathOfBuildingCommunity#8087) * Fix Ynda's Stand not working correctly with Trickster's Escape Artist (PathOfBuildingCommunity#8084) The Belt mod does not affect the amount of evasion on the body armour for the purpose of Trickster's Escape artist node This is also verified on the wiki https://www.poewiki.net/wiki/Ynda%27s_Stand Co-authored-by: LocalIdentity <localidentity2@gmail.com> * Fix Ward rounding final value incorrectly (PathOfBuildingCommunity#8083) Tested with the build in PathOfBuildingCommunity#8073 and many of the values were off by one Messaged the player in game and changing the round -> floor fixed all the final values Co-authored-by: LocalIdentity <localidentity2@gmail.com> * Fix Divine Blessing not removing reservation from skill (PathOfBuildingCommunity#8082) Order of operations error Co-authored-by: LocalIdentity <localidentity2@gmail.com> * Fix Maata's Teaching using wrong crit chance range (PathOfBuildingCommunity#8081) The crit chance mod was updated to compensate for the increased base crit on Karui Septres Co-authored-by: LocalIdentity <localidentity2@gmail.com> * Fix incorrect names for Timeless Jewel nodes (PathOfBuildingCommunity#8080) Some of the stats have been changed over time and since we generate the node name from the alternatepassiveadditions Id, the names were incorrect Also Updates the names for: Add Faster Burn > Add Faster Ignite Add Physical Taken as Fire > Add Rage on Melee Hit Add Ailment Avoid > Add Stun Avoid Add Flask Effect > Add Alchemists Genius Co-authored-by: LocalIdentity <localidentity2@gmail.com> * Add support for Tincture mods (PathOfBuildingCommunity#8078) Adds support for remaining Tincture mods `x% increased Duration of Elemental Ailments from Melee Weapon Attacks` `Melee Weapon Hits have x% chance to ignore Enemy Physical Damage Reduction` `x% increased Damage with Bleeding from Melee Weapons` `+x% to Damage over Time Multiplier with Melee Weapon Attacks` Co-authored-by: LocalIdentity <localidentity2@gmail.com> * Nicer check-empty-build popup (PathOfBuildingCommunity#8077) * Fix infinitely nested XML stored as importLink (PathOfBuildingCommunity#8066) * Added last unique (PathOfBuildingCommunity#8065) * Fix Overexertion not applying to skills linked with Generals Cry (PathOfBuildingCommunity#8040) Added support for overexertion. Also allows any other support gem that would increase Exerted damage to work Co-authored-by: LocalIdentity <localidentity2@gmail.com> * Fix Kaom's Primacy Rage mod not working (PathOfBuildingCommunity#8101) * Fix Kaom's Primacy Rage mod not working GGG changed the wording on the mod so it stopped parsing correctly * Fix wording --------- Co-authored-by: LocalIdentity <localidentity2@gmail.com> * Fix gain on with no chance to mitigate damage (100% suppress chance) (PathOfBuildingCommunity#8121) * add support for some warcry power modifiers (PathOfBuildingCommunity#8130) * in compare mode color a mastery blue when it changed (PathOfBuildingCommunity#8044) Co-authored-by: nofate121 <nofate121@abc.def> * Export from game files * Fix warcry options are not shown in all configurations. (PathOfBuildingCommunity#8173) * fix PathOfBuildingCommunity#8128 * skill list fixed * skill list replaced with ifFlag warcry * added # to configuration options * fix remove all tattoos from removing the tattoos from global list (PathOfBuildingCommunity#8171) * Fix PathOfBuildingCommunity#8162 (PathOfBuildingCommunity#8166) * Explain Exporting Timeless jewels in RELEASE.md and dev help txt (PathOfBuildingCommunity#8161) * Explain Exporting Timeless jewels in RELEASE.md and dev help txt * update explanation for PRing the other repo * Improve Rage calcs tab section (PathOfBuildingCommunity#8145) * fix broken items due to broken bases (PathOfBuildingCommunity#8141) * Minor improvements to Tinctures and Mana Burn (PathOfBuildingCommunity#8135) * Minor improvements to tinctures and mana burn * fix crash * Enable Tincture Effects to also apply to Ranged Weapons (PathOfBuildingCommunity#8134) * add warcry effect mod to calcs tab with breakdown (PathOfBuildingCommunity#8126) * Hide legacy Tattoos from dropdown by default (PathOfBuildingCommunity#8122) * Hide legacy Tattoos from dropdown by default Restricts the Tatoo dropdown to only show the current Tattoos that can drop in the game Need to get the checkbox working that enables the legacy Tatoos to display in the list again * Reload list on changing checkbox * Update StatOrder * Fix checkbox state not staying after closing and reopening --------- Co-authored-by: LocalIdentity <localidentity2@gmail.com> * Fix EHP and Maximum Hit taken with Negative unreserved Life (PathOfBuildingCommunity#8120) * fix calcs tab scroll bar (PathOfBuildingCommunity#8118) * Handle account name spaces in import (PathOfBuildingCommunity#8100) * fix import trim spaces Old code was removing all spaces, regardless of position. * Handle account name spaces by realm type PC: Remove all spaces from account name Console: Trim any leading/trailing space, encode any that remain for URL ("+"). * Enemy damaging ailments (PathOfBuildingCommunity#6814) * add support for enemy damaging ailments fix merge conflict * include recoup and taken over time in ComprehensiveNetLifeRegen * fix spelling * Add support for export and importing warcry buffs to the Party Tab (PathOfBuildingCommunity#8116) * add support for export and importing warcry buffs to the party tab * fix to work with minions * add support for extraWarcryMods (like rallying cry) * fix merge conflict * Add support for pseudo recoup like divine shield and juggernaut (PathOfBuildingCommunity#6833) * Add support for pseudo recoup like divine shield and juggernaut * fix spelling * update rallying cry handling (PathOfBuildingCommunity#8129) * View Gem level sources in calc sections (PathOfBuildingCommunity#8092) * Gem Level stat was enabled and expose in Calc Sections * Use CalcActiveSkills to calculate Mods * Type was fixed in propertyModList * GemLevel Base was moved into CalcActiveSkill --------- Co-authored-by: justjuangui <servicios@juacarvajal.com> * Add ability to search in the spectre library (PathOfBuildingCommunity#8059) * add search to spectre library * move filtering into MinionListControl-lua * adjust layout * add ability to search spectre skills * new layout and separate class for minion search control * select search bar on open --------- Co-authored-by: nofate121 <nofate121@abc.def> * Fix Exerted multipliers applying twice when Dual Wielding (PathOfBuildingCommunity#8174) The calculation is being run for each pass so it is applying the mods twice Co-authored-by: LocalIdentity <localidentity2@gmail.com> * Fix Sand Stance "less damage taken" incorrectly applying to DoT (PathOfBuildingCommunity#8175) The mod was applying a generic DamageTaken instead of just applying to hits Co-authored-by: LocalIdentity <localidentity2@gmail.com> * Fix Hateforge Rage cost calculation (PathOfBuildingCommunity#8176) Hateforge was counting skill gem multipliers in the rage cost calculation when it only cares about the soul cost of the skill Co-authored-by: LocalIdentity <localidentity2@gmail.com> * Fix crash when allocating Blood Magic with Mana Bond (PathOfBuildingCommunity#8177) Allocating Blood Magic removes the output of `ManaUnreserved` so it crashed the preDamageFunc Co-authored-by: LocalIdentity <localidentity2@gmail.com> * Fix Rage Support not enabling Rage damage bonus (PathOfBuildingCommunity#8178) The mod was not applying globally so it wasn't working as a buff Co-authored-by: LocalIdentity <localidentity2@gmail.com> * Export from game files * Release 2.48.0 (PathOfBuildingCommunity#8179) * Prepare release 2.48.0 * Update Changelog --------- Co-authored-by: LocalIdentity <LocalIdentity@users.noreply.github.com> Co-authored-by: LocalIdentity <localidentity2@gmail.com> * Release 2.48.0 --- New to Path of Building --- * Hide legacy Tattoos from dropdown by default (LocalIdentity, Peechey) * Add ability to search in the spectre library (nofate121) * Add Support for Enemy damaging ailments (Regisle) * View Gem level sources in calc sections (justjuangui) * Enable Tincture Effects to also apply to Ranged Weapons (Regisle) * Add support for Tincture mods (LocalIdentity) * Add support for pseudo recoup like Divine Shield and Juggernaut (Regisle) * Add support for some warcry power modifiers (Regisle) * Add Warcry effect mod to calcs tab with breakdown (Regisle) * Add support for export and importing warcry buffs to the Party Tab (Regisle) * Add The Living Blade (Nostrademous) --- Fixed Crashes --- * Fix crash when using Power Charge on Crit from Elder staves (Wires77) * Fix crash when allocating Blood Magic with Manabond (LocalIdentity) --- User Interface --- * Color mastery differences blue when comparing trees (nofate121) * Improve Rage Calcs tab breakdown (Regisle) * Fix Calcs tab scroll bar (Regisle) * Fix full dps visual bug on gem dropdown (Paliak) --- Fixed Calculations --- * Fix Charge duration not using More/Less modifiers (Wires77) * Fix Ynda's Stand Ward conversion mod not taking catalysts into consideration (krfreak) * Fix accuracy of scaled Warcry buffs (Regisle) * Fix Ward rounding final value incorrectly (LocalIdentity) * Fix Hateforge Rage cost calculation (LocalIdentity) * Minor improvements to Tinctures and Mana Burn (Regisle) --- Fixed Behaviours --- * Fix issue where PoB did not detect changes when selecting gems via keyboard shortcuts (nofate121) * Fix The Light of Meaning adding stats to allocated sockets (Paliak) * Fix Rage Effect incorrectly scaling some mods (LocalIdentity) * Fix Rage Support not enabling Rage damage bonus (LocalIdentity) * Fix Arcane Surge effect per Summoned Totem mod not working (LocalIdentity) * Fix Ynda's Stand not working correctly with Trickster's Escape Artist (LocalIdentity) * Fix Divine Blessing not removing reservation from skill (LocalIdentity) * Fix Overexertion not applying to skills linked with Generals Cry (LocalIdentity) * Fix rare case with gain on suppression with no chance to mitigate damage (eg 100% suppress chance) (Regisle) * Fix Warcry options are not shown in all configurations (n1tr0xs) * Fix Tattoos being removed from list when using Remove All Tattoos button (Peechey) * Fix Minions with Endurance Charges still gaining resists (n1tr0xs) * Fix EHP and Maximum Hit taken with negative Unreserved Life (Regisle) * Fix Exerted multipliers applying twice when Dual Wielding (LocalIdentity) * Fix Sand Stance "less damage taken" incorrectly applying to DoT degen (LocalIdentity) --- Accuracy Improvements --- * Update Sap of the Seasons to add new cap (Regisle) * Add variant for post 3.21 Combat Focus (Paliak) * Fix parsing missing for new wording on Emberwake (Paliak) * Fix Maata's Teaching using wrong crit chance range (LocalIdentity) * Fix incorrect names for Timeless Jewel nodes (LocalIdentity) * Fix Kaom's Primacy Rage mod not working (LocalIdentity) * Fix broken base types on some items (Regisle) --- Fixed Bugs --- * Fix infinitely nested XML stored as importLink (Wires77) * Fixes PathOfBuildingCommunity#8182: Enemy crit chance is nil when enemy skill is DoT * Release 2.48.1 (PathOfBuildingCommunity#8183) * Prepare release 2.48.1 * Release v2.48.1 --------- Co-authored-by: Wires77 <Wires77@users.noreply.github.com> * Fix Sublime Vision disabling Mine skills (PathOfBuildingCommunity#8206) Co-authored-by: LocalIdentity <localidentity2@gmail.com> * Fix Damage while Leeching Life mod not working (PathOfBuildingCommunity#8205) The Implicit from Synthesis doesn't currently get parsed Co-authored-by: LocalIdentity <localidentity2@gmail.com> * FEAT: improve breakdown for snipe's damage mods (PathOfBuildingCommunity#8196) * FIX: update snipe skillId (PathOfBuildingCommunity#8195) * Fix limited processing flag not persisting through recursions causing crash (PathOfBuildingCommunity#8192) * FIX: crash due to limited processing flag not persisting between recursive calc.perform calls. This fix may re-introduce PathOfBuildingCommunity#6898 in some cases. * Revert "FIX: crash due to limited processing flag not persisting between" This reverts commit 1a19ab0. * FIX: limited processing flag not persisting through recursions * FIX: spelling * Release 2.48.2 (PathOfBuildingCommunity#8207) * Prepare release 2.48.2 * Fix Changelogs --------- Co-authored-by: LocalIdentity <LocalIdentity@users.noreply.github.com> Co-authored-by: LocalIdentity <localidentity2@gmail.com> * Release 2.48.2 VERSION[2.48.2][2024/08/17] --- Fixed Crashes --- * Fix limited processing flag not persisting through recursions causing crash (Paliak) --- User Interface --- * Improve breakdown for Snipe's damage mods (Paliak) --- Fixed Calculations --- * Fix Damage while Leeching Life mod not working (LocalIdentity) --- Fixed Behaviours --- * Fix Sublime Vision disabling Mine skills (LocalIdentity) * Fix Snipe for Assailum not working (Paliak) VERSION[2.48.1][2024/08/15] --- Fixed Crashes --- * Fix crash when selecting Damage Over Time as the Enemy Damage Type (Wires77) * Add support for Debuffs granted by Glorious Madness (PathOfBuildingCommunity#8275) * Add support for Debuffs granted by Glorious Madness Using the Embrace Madness skill grants you 4 unique debuffs that accumulate up to 10 stacks. We were also missing 1 explicit mod on each variant of the boots * Spelling mistake --------- Co-authored-by: LocalIdentity <localidentity2@gmail.com> * Add support for Storm Secret self damage calculation (PathOfBuildingCommunity#8274) * Add support for Storm Secret self damage calculation Adds support for the self damage calculated when a Herald of Thunder Storm hits an enemy * Wrap loop with skill check first --------- Co-authored-by: LocalIdentity <localidentity2@gmail.com> * minor code fixes (PathOfBuildingCommunity#8267) * Add Wretched Defiler Spectre (PathOfBuildingCommunity#8242) * add wr skill * add WRETCHED DEFILERS * add Wretched Defiler info * Fix Spectre export * Fix Eldritch Implicit Mod Replacement (PathOfBuildingCommunity#8265) * show curse limit on curses (PathOfBuildingCommunity#8263) * Change default Boss Config (PathOfBuildingCommunity#8271) * Fix config always applying * Add support for modifying affix limits (PathOfBuildingCommunity#8258) * Add support for modifying affix limits * fix magic item limits and names * add support for Items Implicits Cannot Be Changed (PathOfBuildingCommunity#8243) * FEAT: implement settlers trigger enchant (PathOfBuildingCommunity#8240) * FIX: hide line if recovery is 0 on mana flask (PathOfBuildingCommunity#8239) * fix PathOfBuildingCommunity#8234 (PathOfBuildingCommunity#8237) * Validate mode before saving settings (PathOfBuildingCommunity#8235) * FIX: validate mode before saving settings * FIX: typo * FIX: mana cost raw not being set to 0. Add breakdown line. (PathOfBuildingCommunity#8233) * Make runesmith enchants an enchant instead of a craft (PathOfBuildingCommunity#8223) * make runesmith enchants an enchant instead of a craft * fix spec description function * make passive hash not spam consol * Adds parsing for local elemental inc damage (PathOfBuildingCommunity#8222) * adds parsing for local elemental inc damage * fix it not applying to ele menetal * fix PathOfBuildingCommunity#8216 (PathOfBuildingCommunity#8218) * Add Support for many Runecraft Enchants (PathOfBuildingCommunity#8217) Adds support for the following mods: Gain Arcane Surge after Spending a total of 200 Life Adds 5% of your Maximum Energy Shield as Cold Damage to Attacks with this Weapon Adds 5% of your Maximum Mana as Fire Damage to Attacks with this Weapon Damage cannot be Reflected Mana Leech from Hits with this Weapon is Instant Chaos Damage with Hits is Lucky (7-10)% increased Fire Damage per 1% Fire Resistance above 75% Mods that still need support: Haunted by Tormented Spirits Trigger a Socketed Fire Spell on Hit, with a 0.25 second Cooldown Gain Flaming, Icy or Crackling Runesurge at random for 4 seconds every 10 seconds Gain a random shrine buff every 10 seconds Co-authored-by: LocalIdentity <localidentity2@gmail.com> * Default to last added Tattoo in Tattoo popup (PathOfBuildingCommunity#8215) Adding multiple Tattoos is a pain when you have to re-enter the name of the Tattoo every time you are trying to add another copy of it Co-authored-by: LocalIdentity <localidentity2@gmail.com> * fix invalid skill ids in party tab source (PathOfBuildingCommunity#8211) * Added ignore mirrored items checkbox to trade query options. (PathOfBuildingCommunity#8184) * added checkbox for mirrored items * added query generation for mirrored items * ModCache * fix Dual Wielding Mastery Elusive on block not enabling config (PathOfBuildingCommunity#8277) * Update Affliction Spectres with 3.25 Changes (PathOfBuildingCommunity#8279) Quite a few of the corpse spectres has their mods updated or removed. These mods are manually added so needed to be manually updated if GGG changes them Co-authored-by: LocalIdentity <localidentity2@gmail.com> * Fix The Taming affecting Elemental Ground DoTs (PathOfBuildingCommunity#8286) The Taming is only meant to apply to Hits and Ailments but was just applying generically to everything Co-authored-by: LocalIdentity <localidentity2@gmail.com> * Fix Frost Blades of Katabasis DoT not scaling with Tinctures and Multistrike (PathOfBuildingCommunity#8281) * Fix Frost Blades of Katabasis DoT not scaling with some mods The DoT portion of the skill was not scaling with the `(70-100)% increased Elemental Damage with Melee Weapons` mod on Tinctures. It was also not scaling with the repeat damage on Multistrike. I tested it in game and the repeat damage definitely applies to the DoT component. The PR removes the skill hit tag from the DoT component so it doesn't incorrectly show hit damage and stats It also removes crit chance from showing up unless a skill part has a hit component * Fix DoT Multi mod not working correctly --------- Co-authored-by: LocalIdentity <localidentity2@gmail.com> * Change controls to take a packed "rect" instead of x, y, width, height (PathOfBuildingCommunity#6873) * change controls to take a packed "rect" instead of x, y, width, height * Fix bad merge * Add missing box notation * fix merge issues and update new controls to use packed rect * update export * fix white space * fix spelling mistake * fix more merge issues --------- Co-authored-by: Wires77 <Wires77@users.noreply.github.com> * Update CONTRIBUTING.md about committing ModCache.lua * fix overrides 0 showing up when eval mod fails (PathOfBuildingCommunity#8306) * Change config types to `count allow zero` (PathOfBuildingCommunity#8305) * Fix Dual Strike of Ambidexterity and Cleave of Rage (PathOfBuildingCommunity#8304) * Fix Dual Strike of Ambidexterity and Cleave of Rage * fix whitespace * Remove non-existant stat from Cadigan's Crown (PathOfBuildingCommunity#8294) Im not sure how this got there: Nearby Enemies cannot deal Critical Strikes Signed-off-by: Tomas Slusny <slusnucky@gmail.com> * fix Ghost Reaver and Brutal Fervour Interaction (PathOfBuildingCommunity#8290) * Add Ctrl+Alt+c error popup (PathOfBuildingCommunity#8287) * Fix 3.1 xp multiplier calc for levels 95-99 (PathOfBuildingCommunity#8283) * fix 3.1 xp multiplier calc for levels 95-99 * corrected lvl 97 multplier * Fixed Cluster notable cap (PathOfBuildingCommunity#8280) * add back weight multiplier keys * add weight key for large clusters * Fix Trade Query Stat Weight Crash (PathOfBuildingCommunity#8278) * Fix Trade Query Stat Weight Crash * Update TradeQuery.lua --------- Co-authored-by: LocalIdentity <31035929+LocalIdentity@users.noreply.github.com> * Shock and scorch fixes (PathOfBuildingCommunity#8272) * fix max stacks * fix calcs tab value and lightning conduit etc * Fix numerous fullDPS tooltip issues (PathOfBuildingCommunity#8247) * FIX: numerous fullDPS issues * FIX: output reuse and acceleration without existing env * FIX: prevent calculation of fullDPS if it's not needed for item sorting * Update rare templates (PathOfBuildingCommunity#8229) * sort all bases and fix trapsetter gloves * update to new bases * fix newlines * Add support for exporting bases * update mods on bases and add some new items * fix party tab warcries clearing links instead of warcries (PathOfBuildingCommunity#8313) * fix PartyTab Crash with thresholds (PathOfBuildingCommunity#8314) * Fix Advanced Item Description error popup problems (PathOfBuildingCommunity#8311) * show as warning, once per session * move to keypress handling code * Export from game files * FEAT(warnings): add name of source causing requirements warning to warning message (PathOfBuildingCommunity#8335) * Move build display stats to its own file (PathOfBuildingCommunity#8337) * Move build display stats to its own file * add comments * fix merge issue * Fix abyss socket items with no selectableSocketCount (eg Wraithlord) (PathOfBuildingCommunity#8317) * Implement Enemy Damage Type defaulting to "Average" after user swaps off of a Boss Skill Preset other than None. (PathOfBuildingCommunity#8318) * Improve EHP overkill approximation, especially for MoM (PathOfBuildingCommunity#7568) * Hollow Palm Technique proper Dual Wielding (PathOfBuildingCommunity#8307) * Vengeful Cry Improvements (PathOfBuildingCommunity#8303) * Vengeful Cry Improvements * remove disable by default * Fix import with discriminators (PathOfBuildingCommunity#8361) * fix Import With Discriminators * make it use `#` instead of `-` * update to only gsub on page downloads, and fix account name dropdown * fix saved value * cleanup extra gsub * Fix Warden Import Colour (PathOfBuildingCommunity#8362) * FIX: special characters in set name causing crash (PathOfBuildingCommunity#8353) Makes loadout matching logic use plain text pattern finding to allow use of reserved characters in set names. * Fixed Empty actor item detection (PathOfBuildingCommunity#8331) Changed independent IF statements in CalcPerform into single if-elseif statement. * Added Changes (PathOfBuildingCommunity#8330) Calculations fixed, mod inc display edge case issue. * FIX: broken tests after changing default boss preset (PathOfBuildingCommunity#8327) Due to PathOfBuildingCommunity#8271 changing the default boss preset many tests that relied on enemy stats broke. This pr fixes that by changing the boss configuration back to "None" for affected tests. Additionally this commit adds an extra test for scorching ray exposure when using the automatic maximum sustainable stages mode. * Fix blasphemy auras triggering mana cost warning (PathOfBuildingCommunity#8324) * FIX: Blasphemy auras triggering mana cost warning The warning calculations did not consdier the case of a skill having both reservation and mana costs. Mana cost would be checked after applying reservation and not before causing the warning to show up in some cases. This pr adds a check and handling for such cases, as well as using the warnings from output to determine color override for cost labels instead of re-checking pool availability. * Update Calcs.lua --------- Co-authored-by: LocalIdentity <31035929+LocalIdentity@users.noreply.github.com> * FIX: kalandra's touch stat copying (PathOfBuildingCommunity#8323) Kalandra's touch ignored item overrides causing the tooltip to only show stat difference when unequipping the copied ring. During filtering of mods an iterator was modified causing some mods to be skipped. * Fix Rupture sometimes applying multiple times (PathOfBuildingCommunity#8320) * fix issue PathOfBuildingCommunity#8259 - rupture applying multiple times * add changes to sup_dex.txt as well --------- Co-authored-by: majochem <majochem@users.noreply.github.com> * Fix exporter Add new datatype UInt16 Removed old dats Manually code in SkillTotem loop Update spec * Release 2.49.0 (PathOfBuildingCommunity#8363) * Prepare release 2.49.0 * Update changelog --------- Co-authored-by: LocalIdentity <LocalIdentity@users.noreply.github.com> Co-authored-by: LocalIdentity <localidentity2@gmail.com> * Release 2.49.0 --- New to Path of Building --- * Fix character import for accounts with discriminators (Regisle) * Change default Boss Config from None to Pinnacle (Regisle) * Default to last added Tattoo in Tattoo popup (LocalIdentity) * Add support for Debuffs granted by Glorious Madness (LocalIdentity) * Add support for Storm Secret self damage calculation (LocalIdentity) * Add Wretched Defiler Spectre (machenme) * Add support for modifying affix limits (Regisle) * Add support for Items Implicits Cannot Be Changed (Regisle) * Add Support for many Runecraft Enchants by (LocalIdentity, Regisle, Paliak) * Add Ctrl+Alt+c error popup (Nightblade) * Update rare templates (Regisle) * Add name of item causing requirements warning to warning message (Paliak) * Update Affliction Spectre Buffs with 3.25 Changes (LocalIdentity) --- Fixed Crashes --- * Fix invalid skill IDs in party tab source (Regisle) * Fix Trade Query Stat Weight Crash (Regisle) * Fix Party Tab Crash with thresholds (Regisle) * Fix special characters in set name causing crash (Paliak) --- User Interface --- * Show Curse limit on calcs tab (Regisle) * Add "Ignore Mirrored Items" checkbox to trade query options (n1tr0xs) * Hide recovery information on Mana Flasks if recovery is 0 (Paliak) * Allow zero enemy armour in config and fix negative enemy damage (Regisle) * Fix Warden import colour (Regisle) --- Fixed Calculations --- * Mana cost raw not being set to 0 when using lifetap (Paliak) * Fix Frost Blades of Katabasis DoT not scaling with Tinctures and Multistrike (LocalIdentity) * Fix 3.1 xp multiplier calc for levels 95-99 (OriginalThing) * Shock and scorch fixes (Regisle) * Improve EHP overkill approximation, especially for MoM (0xjc) * Hollow Palm Technique proper Dual Wielding (Regisle) * Fixed Off hand detection regarding Necromantic Aegis (Jonathan-Dang) * Fix Herald of Ash overkill damage incorrectly scaling with global damage increases (Jonathan-Dang) --- Fixed Behaviours --- * Fix Blasphemy Auras triggering Mana cost warning (Paliak) * Fix Eldritch Implicit Mod Replacement (Regisle) * Fix Bloodscent not making Rage eligible (n1tr0xs) * Fix "# of Warcries used recently" configuration option unavailable (n1tr0xs) * Fix The Taming affecting Elemental ground DoTs (LocalIdentity) * Fix Dual Strike of Ambidexterity and Cleave of Rage (Regisle) * Fix Ghost Reaver and Brutal Fervour Interaction (Regisle) * Fix abyss socket items with no selectable Socket count (e.g. Wraithlord) (Regisle) * Default "Enemy Damage Type" to "Average" when changing Boss skills (ConnorThelin) * Vengeful Cry Improvements (Regisle) * Fix Kalandra's Touch skipping mods (Paliak) * Fix Rupture sometimes applying multiple times (majochem) --- Accuracy Improvements --- * Make Runesmith enchants an enchant instead of a craft (Regisle) * Fix Cooldown breakdown showing overrides for other skills (e.g. Flicker) (Regisle) * Remove non-existant stat from Cadigan's Crown (deathbeam) * Fix numerous fullDPS tooltip issues (Paliak) --- Other changes --- * Fix Dual Wielding Mastery "Elusive on block" not enabling Elusive config (Regisle) * Fix Party Tab Warcries clearing links instead of Warcries (Regisle) * fix: allow xbox and sony realms characters import (PathOfBuildingCommunity#8365) * Changelogs * Release 2.49.1 --- Fixed Bugs --- * Fix character import for Xbox and Playstation accounts (HashBR) * Add discriminator check to account import (PathOfBuildingCommunity#8366) * add Discriminator To Account Debug Steps * add preventative measures and extra warnings * 1234 instead of 0000 * Changelogs * Release 2.49.2 --- User Interface --- * Validate discriminator is in account name on import (Regisle) * bump cspell-action to v6.9.0 (PathOfBuildingCommunity#8368) * filter for only poe1 realms and fix sorting (PathOfBuildingCommunity#8367) * fix: allow account names with dashed in them to be imported correctly (PathOfBuildingCommunity#8370) * fix: allow account names with dashed in them to be imported correctly * move ReplaceCharAtIndex to Common.lua and fix indent * Simplify logic --------- Co-authored-by: Clemens Himmer <clemens@himmer.software> Co-authored-by: Wires77 <Wires77@users.noreply.github.com> * remove url encoding check, as it was broken (PathOfBuildingCommunity#8372) * Fix export scripts latest updated add a row to Mods.dat which has no ModFamily entry * Update query mods * Changelog * Release 2.49.3 --- Fixed Bugs --- * Fix character import from accounts with a hyphen in them (tarekis) * Fix trade realms not sorting correctly (Regisle) * Use new datc64 files for export Changes the exporter to use the new datc64 files and the regular dat64 files be be deprecated at some point Fixes the spec for a number of tables that were changed to use the new UInt16 type * Update release.yml * Implement a docker container for tests (PathOfBuildingCommunity#8199) * FEAT: implement container for tests * FEAT: add action for building image * FIX: pin luajit by hash instead of tag * FIX: typo * improve "set up the exporter" tutorial (PathOfBuildingCommunity#8387) * improve "set up the exporter" tutorial amend: typo, format * Update CONTRIBUTING.md just noticed the path is different for stand-alone and steam installs ... * Update to PoBC's image * fix caps/spelling/space (PathOfBuildingCommunity#8371) EHPsurvivalTime -> EHPSurvivalTime atleast -> at least delete random space * Adding workflow_dispatch so I can re-run failed PR checks * Update Docker compose file to use new image * Add game version parameter to installer script * fix PathOfBuildingCommunity#8388 (PathOfBuildingCommunity#8390) * Remove statOrderKey * FIX(fulldps): propagate overrides from inside of initEnv (PathOfBuildingCommunity#8392) * Fix unparsed item text "Block chance" * Update stat requirement formula * FIX(mods): GemProperty mod not being affected by scaling (PathOfBuildingCommunity#8409) * Add poedb.tw to import website list (PathOfBuildingCommunity#8401) * FEAT!: implements lua side hotkey for screenshots (PathOfBuildingCommunity#8414) Changes the hotkey from just prints screen to control print screen to prevent potential conflicts with other screenshot programs. * Restore plus sign for Tavukai Fixes PathOfBuildingCommunity#8422 * Automate creating PR for SimpleGraphic releases (PathOfBuildingCommunity#8425) * Add SG workflow * Fix repo name * Fix repo owner * Update to SimpleGraphic v2.2.0 (PathOfBuildingCommunity#8441) * Update DLLs to SimpleGraphic-v2.2.0 * Delete runtime/SimpleGraphicDLLs-x64-windows.tar --------- Co-authored-by: Wires77 <Wires77@users.noreply.github.com> * Fix fallout from SimpleGraphic upgrade with wider Unicode support (PathOfBuildingCommunity#8412) * fix: enable Unicode separators and caret motions As the runtime is going to support Unicode installation locations and build directories, some UTF-8 text is going to reach the Lua side of the project. This includes the script path, the user path, any paths yielded from file searches and also imported character names from accounts. Care needs to be taken in many places where string operations are performed as no longer does a byte necessarily correspond to a single character and anything that truncates, reverses or otherwise slices strings could need an audit. This change fixes cursor movement in `EditControl`s with the arrow keys as those historically used string matching and byte offsets. It also ensures that the use of arbitrary Unicode codepoints as decimal and thousands separators works correctly as the previous code used unaware reversing and slicing. * fix: turn update paths relative for wide installs The updater is a fixed piece of older code that uses a Lua runtime that only handles paths that are representable in the user's text codepage. As the software may be installed in a location that cannot be expressed in that way, to mitigate the problem we turn all the paths in the update op-files into relative paths. That way as long as we never use exotic codepoints in our own paths it should be able to apply them cleanly and restart Path of Building afterward with a relative path. The updater executable can ironically enough not be updated at all with the related type of runtime hacks we introduced in SimpleGraphic as the updater deadlocks in updating itself. We have to work around its shortcomings in how we produce the op-files and possibly the update application script that runs under that limited runtime. * fix: convert GIFs masquerading as PNG to PNG Upon removing support for several file formats like GIF and BLP from the SimpleGraphic runtime, we noticed that there were some assets that had incorrect file extensions and loaded only thanks to file format detection ignoring extensions. As the actual file format loader for GIF was removed, these stealth GIFs are now losslessly converted to PNG. * Add luautf8 to Dockerfile --------- Co-authored-by: Wires77 <Wires77@users.noreply.github.com> * Update launcher for UTF-8 * Clarify which PoB edition this is for, (PathOfBuildingCommunity#8435) and make it clearer that we need a build code from PoB. * fix caps pob-poe1 edition (PathOfBuildingCommunity#8452) Give some words proper caps to keep spellcheckers and (some) human eyes happy. * fix PathOfBuildingCommunity#8418 (PathOfBuildingCommunity#8419) * Add support for Legacy Of Phrecia Ascendancies (PathOfBuildingCommunity#8449) * Reduced Vaal soul cost * Attack block lucky/unlucky * Immune to curses while channelling * Unlucky hit damage --------- Co-authored-by: LocalIdentity <localidentity2@gmail.com> * docs: update readme.md, contributing.md (PathOfBuildingCommunity#8438) * Regen ModCache * Remove carriage returns from release notes * Add Support for Shrine buffs from The Gull and staff Rune craft (PathOfBuildingCommunity#8457) * Add support for Shrine Buffs Adds support for Shrine buffs granted by The Gull and all the regular shrines grated by the Staff rune craft and the upcoming Legacy of Phrecia event * Formatting --------- Co-authored-by: LocalIdentity <localidentity2@gmail.com> * Add more Legacy of Phrecia Mods (PathOfBuildingCommunity#8456) * Add more Legacy of Phrecia Mods Adds support for the following mods +1 to Maximum Mana per Dexterity 100% of Physical Damage is taken from Mana before Life 20% Chance to gain Elemental Conflux for 4 seconds when you Kill an Enemy Spell Skills deal no Damage 30% more Maximum Attack Damage Spells fire 2 additional Projectiles Immune to Reflected Damage Triggers Level 20 Abberath's Fury - Damage is unknown for level 20 though * Add Jewels for each event Ascendancy --------- Co-authored-by: LocalIdentity <localidentity2@gmail.com> * Improve EHP accuracy (PathOfBuildingCommunity#8430) * Improve EHP accuracy * Hunting more corner cases MoM with ES when there is ES bypass was not capping effective ES. MoM with life loss prevention was not accounting for the multiplied life effectiveness when reducing pools. Max hit smoothing (for conversion + armour) now uses pool reduction to effectively home in on a precise max hit. * Hunting more corner cases MoM with ES when there is ES bypass was not capping effective ES. MoM with life loss prevention was not accounting for the multiplied life effectiveness when reducing pools. Max hit smoothing (for conversion + armour) now uses pool reduction to effectively home in on a precise max hit. * Fixed interaction between block replacement effect from Determined Survivor and Necromantic Aegis (PathOfBuildingCommunity#8417) * Fixed interaction between block replacement effect from ascendancy with Necromantic Aegis Fixes interaction between Block Replacement effect granted from Gladiator's "Determined Survivor" ascendency with Necromantic Aegis. * Improved Changed to allow for more flexibility. Co-authored-by: Paliak <91493239+Paliak@users.noreply.github.com> * Wrong Variable Needs to be baseBlockChance or else it doesn't have the complete 50% block chance granted from Ascendency. * Update CalcDefence.lua * Corrected Affected Variables. * Last Fix --------- Co-authored-by: Paliak <91493239+Paliak@users.noreply.github.com> * FEAT: Implement ability to delete folders with contents (PathOfBuildingCommunity#8416) Lua side code for: PathOfBuildingCommunity/PathOfBuilding-SimpleGraphic#63 Based on: PathOfBuildingCommunity#8197 * Fixed Non-Damaging Ailment issue with Critical Mastery (PathOfBuildingCommunity#8393) Fixed an issue where Critical Hits were not displaying the Critical Mastery Node increasing non-damaging ailment effect mod to critically strike enemies. * fix viper strike of mamba poison (PathOfBuildingCommunity#8253) * Revert sidebar poison to split posion dps again (PathOfBuildingCommunity#8254) * split poison dps again and make sidebar use single poison * Fix build --------- Co-authored-by: LocalIdentity <localidentity2@gmail.com> * Disable `gain when hit` for builds which cannot survive unlucky hits (PathOfBuildingCommunity#8342) * Update how Influences are handled (PathOfBuildingCommunity#8257) * Fix display * Update query mods * Release 2.50.0 (PathOfBuildingCommunity#8458) * Prepare release 2.50.0 * Fix Changelog --------- Co-authored-by: LocalIdentity <LocalIdentity@users.noreply.github.com> Co-authored-by: LocalIdentity <localidentity2@gmail.com> * Release 2.50.0 --- New to Path of Building --- * Add support for Legacy Of Phrecia Ascendancies (LocalIdentity) * Add unique jewel for each Ascendancy to make it easier to test * Add Support for Shrine buffs from The Gull and staff Rune craft (LocalIdentity) * Add poedb.tw to import website list (Chuanhsing) * Basic Unicode support (zao) * Implement ability to delete folders with contents (Paliak) --- Fixed Crashes --- * Fix crash related to trigger calculations (Paliak) --- Fixed Calculations --- * Fix Viper Strike of Mamba poison (Regisle) * Improve EHP accuracy (Edvinas-Smita) * Fixed Non-Damaging Ailment issue with Critical Mastery in Calc Screen (Jonathan-Dang) --- Fixed Behaviours --- * Fixed interaction between block replacement effect from Determined Survivor and Necromantic Aegis (Jonathan-Dang) * Disable "gain when hit" for builds which cannot survive unlucky hits (Regisle) --- User Interface --- * Show Poison DPS in sidebar as the DPS for a single poison (Regisle) --- Fixed Bugs --- * Fixes Cinderswallow Urn missing the damage taken mod (n1tr0xs) * Update Breathstealer's unique mods (n1tr0xs) * Fix "Full Poison DPS" value capping to one stack (PathOfBuildingCommunity#8460) * Fix Full Poison DPS only showing one poison stack * Cap from multiple sources * Backport release note fixes from PoB2 * Release 2.50.1 (PathOfBuildingCommunity#8461) --- Fixed Calculations --- * Fix "Full Poison DPS" value capping to one stack (Wires77) * Fix bad merge * Fix maximum virulence parsing for multi digit increases (PathOfBuildingCommunity#8463) +25 virulence from the herald ascendancy for example Signed-off-by: Tomas Slusny <slusnucky@gmail.com> * Fix O -> 0 on maximum charges mod * fix-typos-comments (PathOfBuildingCommunity#8466) Should be fine to merge as they're only in comments. threshhold Controlls * Carriage return is not always present in release notes * Fix various issues with Legacy of Phrecia ascendancies (PathOfBuildingCommunity#8465) * Add Wildspeaker, Blind Prophet, Aristocrat and Puppeteer jewels (PathOfBuildingCommunity#8471) Adds jewels for the new ascendancies Adds 2 mods to other ascendancies that GGG noted on twitter Co-authored-by: LocalIdentity <localidentity2@gmail.com> * Add Ancestral Commander, Behemoth, Bog Shaman, and Scavenger Ascendancy Jewels (PathOfBuildingCommunity#8476) * add Ancestral Commander, Behemoth, Bog Shaman, Scavenger ascendancy Jewels * g is not q * behemoth fix * bog shaman fix * Bog Shaman - Rotten Core parsing and ModCache * PoB2 PathOfBuildingCommunity#694 backport (PathOfBuildingCommunity#8459) * Support Power of Purpose parsing * Fix release note script typo * Release 2.51.0 (PathOfBuildingCommunity#8477) --- New to Path of Building --- * Add Wildspeaker, Blind Prophet, Aristocrat and Puppeteer ascendancy jewels (LocalIdentity) * Add Ancestral Commander, Behemoth, Bog Shaman, and Scavenger ascendancy jewels (Peechey) --- Fixed Calculations --- * Fix maximum virulence parsing for multi-digit increases (deathbeam) * Fix "Full Poison DPS" value capping to one stack (Wires77) * Fix ES bypass regression (Edvinas-Smita) --- Accuracy Improvements --- * Fix various issues with Legacy of Phrecia ascendancies (Wires77) --------- Co-authored-by: Wires77 <Wires77@users.noreply.github.com> * Update amulet.lua (PathOfBuildingCommunity#8483) Wording fix * Add tree for Legacy of Phrecia (PathOfBuildingCommunity#8494) * Add Legacy of Phrecia trees * Support import/export of tree links * Remove debugging lines * Remove temporary jewels * Restore English Harbinger node names * Fixup PoEPlanner import * Have tree conversion respect new alternate version * Change ascendancy names in the dropdown when the tree version changes * Identify imported tree version based on ascendancy name * Update class name colors in the import tab * Fixes PathOfBuildingCommunity#8498: Use new influence table structure even in ImportTab (PathOfBuildingCommunity#8500) * duration tag was on meteors instead of pelting (PathOfBuildingCommunity#8493) * FEAT: add default on checkbox for Sacrificial Zeal (PathOfBuildingCommunity#8481) * Add black background to detail text in character dropdown (PathOfBuildingCommunity#8487) * FIX: add black background to detail text in character dropdown Character names are currently drawn over the top of the details on the right of the dropdown. If a name happens to be very long (often happens when using tofu for utf-8) the details stop being legible. This adds a black background behind the detail text to make it more readable. * FIX: fix import dropdown detail visibility when no explicit color code is used * Fixed some bugs with infinite EHP and wrong phys max hit (PathOfBuildingCommunity#8495) * Add Molten Strike (+Zenith) ball average overlap calculations (PathOfBuildingCommunity#8427) * add average ball overlap calcs for molten strike * add average ball overlap calcs for molten strike of the zenith as well as a total weighted average of normal balls and 5th attack balls * copy molten strike overlap changes to export scripts * Fix spelling --------- Co-authored-by: Wires77 <Wires77@users.noreply.github.com> * Release 2.52.0 (PathOfBuildingCommunity#8501) * Prepare release 2.52.0 * Update manifest * Fix missing line break --------- Co-authored-by: Wires77 <Wires77@users.noreply.github.com> * Fix manifest error * Release 2.52.1 (PathOfBuildingCommunity#8502) * Prepare release 2.52.1 * Update CHANGELOG.md * Update manifest --------- Co-authored-by: Wires77 <Wires77@users.noreply.github.com> * FIX: mirage calcs crash due to missing srcInstance (PathOfBuildingCommunity#8507) * Fix Forbidden jewels not finding the right ascendancy nodes (PathOfBuildingCommunity#8508) * Expand width of tree and ascendancy dropdowns (PathOfBuildingCommunity#8506) * Update tree data with missing cluster jewel nodes (PathOfBuildingCommunity#8505) * Release 2.52.2 (PathOfBuildingCommunity#8509) VERSION[2.52.2][2025/02/20] --- Fixed Crashes --- * Fix Tawhoa's Chosen crash when no active skill is enabled (Paliak) --- User Interface --- * Dynamically expand some dropdowns that were too narrow to read (Wires77) --- Fixed Behaviours --- * Fix Forbidden jewels not finding the right ascendancy nodes (Wires77) * Update tree data with missing cluster jewel nodes (Wires77) --------- Co-authored-by: Wires77 <Wires77@users.noreply.github.com> * Export from Legacy of Phrecia event (PathOfBuildingCommunity#8516) * Fix fishing enchant (PathOfBuildingCommunity#8518) * Fix fishing rod item class for enchants * Export enchant * Fix harbinger text and ascendancy positions * Regenerate ModCache and add new harbinger skills (PathOfBuildingCommunity#8519) * Release 2.52.3 (PathOfBuildingCommunity#8520) --- New to Path of Building --- * Add new Harbinger skills (Wires77) --- Fixed Bugs --- * Fix error when crafting a fishing rod enchant (Wires77) --------- Co-authored-by: Wires77 <Wires77@users.noreply.github.com> --------- Signed-off-by: Tomas Slusny <slusnucky@gmail.com> Co-authored-by: Paliak <91493239+Paliak@users.noreply.github.com> Co-authored-by: LocalIdentity <31035929+LocalIdentity@users.noreply.github.com> Co-authored-by: LocalIdentity <localidentity2@gmail.com> Co-authored-by: dreais <55636511+dreais@users.noreply.github.com> Co-authored-by: Connor Thelin <63825961+ConnorThelin@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: LocalIdentity <LocalIdentity@users.noreply.github.com> Co-authored-by: Nighty <Nightblade@users.noreply.github.com> Co-authored-by: Wires77 <Wires77@users.noreply.github.com> Co-authored-by: nofate121 <44315619+nofate121@users.noreply.github.com> Co-authored-by: nofate121 <nofate121@abc.def> Co-authored-by: Tim Schnell <kreedzfreak@gmail.com> Co-authored-by: Regisle <49933620+Regisle@users.noreply.github.com> Co-authored-by: Nostrademous <nostrademous@hotmail.com> Co-authored-by: Никита Троянов <36129181+n1tr0xs@users.noreply.github.com> Co-authored-by: Peechey <92683202+Peechey@users.noreply.github.com> Co-authored-by: Juangui <80857657+justjuangui@users.noreply.github.com> Co-authored-by: justjuangui <servicios@juacarvajal.com> Co-authored-by: ma chen <117664524+machenme@users.noreply.github.com> Co-authored-by: Tomas Slusny <slusnucky@gmail.com> Co-authored-by: OriginalThing <someoriginalthing@gmail.com> Co-authored-by: 0xjc <5281913+0xjc@users.noreply.github.com> Co-authored-by: Jonathan Dang <77904634+Jonathan-Dang@users.noreply.github.com> Co-authored-by: majochem <77203255+majochem@users.noreply.github.com> Co-authored-by: majochem <majochem@users.noreply.github.com> Co-authored-by: Túlio Campos <32376203+HashBR@users.noreply.github.com> Co-authored-by: Clemens Himmer <jackyboy@live.at> Co-authored-by: Clemens Himmer <clemens@himmer.software> Co-authored-by: Chuanhsing <chuanhsing@gmail.com> Co-authored-by: Lars Viklund <zao@zao.se> Co-authored-by: Edvinas-Smita <36479307+Edvinas-Smita@users.noreply.github.com> Co-authored-by: henbe <holypush@yandex.ru> Co-authored-by: Andy Li <32141296+andyli00@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main reason to do this is that it doesnt feel like this belongs where it is, its hard for new contributors to find without running a search on the files, and this has other issues that have built up over time like duplication of entries, and splitting it off like this makes it easier to implement something like #5752 in future.
There are a few other changes that could be done but I am leaving those either for future PRs or for feedback, namely
vandousevalueandoutput)