Skip to content

Prevent irrelant tags on secondaryEffect gems and support gems being saved to xml #5700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

QuickStick123
Copy link
Contributor

@QuickStick123 QuickStick123 commented Feb 19, 2023

Description of the problem being solved:

This fixes minion stuff not being deletable off non minion skill w/ secondary stuff (mostly vaal) and similar.
Fixes replacing an active skill with a support leeching stats.

Still seems to be a few lingering problems.

  1. The above fix wasn't done for stages as they are handled with a cfg and wasn't sure how to easily make one for secondary Effect this means if there is a support that adds stages vaal gems could see this tag leeching or something similar.
  2. Disabling a support gem seem to still let the flags to get saved to the xml but updating any of the calculations remedies this so might not be rebuilding when it should. Calc active skill not called? As updating anything seems to fix it. Inconsistent as well.
  3. Disabled skills do not seem to get rebuild and so tags remain in xml.

@QuickStick123 QuickStick123 added the technical Hidden from release notes label Feb 19, 2023
@QuickStick123 QuickStick123 force-pushed the try-to-delete-more-aggressively branch from 176d705 to a29428d Compare December 20, 2023 05:25
@QuickStick123 QuickStick123 changed the title Narrow details to not delete relevant field on srcInstance for secondary effect Delete relevant fields on secondaryEffect gems and clean support gems to prevent irrelant tags saved to xml Dec 20, 2023
@QuickStick123 QuickStick123 changed the title Delete relevant fields on secondaryEffect gems and clean support gems to prevent irrelant tags saved to xml Delete relevant fields on secondaryEffect gems and support gems to prevent irrelant tags saved to xml Dec 20, 2023
@QuickStick123 QuickStick123 changed the title Delete relevant fields on secondaryEffect gems and support gems to prevent irrelant tags saved to xml Prevent irrelant tags on secondaryEffect gems and support gems being saved to xml Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical Hidden from release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant