Skip to content

Fix skill level mod not applied to skill granted by items #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Fix skill level mod not applied to skill granted by items #796

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd886d5
fix-721
mauriliogenovese Feb 16, 2025
93f5a8f
missing gemId
mauriliogenovese Feb 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Modules/CalcSetup.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1274,8 +1274,8 @@ function calcs.initEnv(build, mode, override, specEnv)
enabled = true,
}
activeGemInstance.fromItem = grantedSkill.sourceItem ~= nil
activeGemInstance.gemId = nil
activeGemInstance.level = grantedSkill.level
activeGemInstance.gemId = data.gemForSkill[data.skills[grantedSkill.skillId]]
activeGemInstance.enableGlobal1 = true
activeGemInstance.noSupports = grantedSkill.noSupports
group.noSupports = grantedSkill.noSupports
Expand Down Expand Up @@ -1597,7 +1597,7 @@ function calcs.initEnv(build, mode, override, specEnv)
t_insert(env.player.activeSkillList, activeSkill)
end
end
if gemInstance.gemData and not accelerate.requirementsGems then
if gemInstance.gemData and not (accelerate.requirementsGems or group.gemList[gemIndex].fromNode or group.gemList[gemIndex].fromItem) then
t_insert(env.requirementsTableGems, {
source = "Gem",
sourceGem = gemInstance,
Expand Down