-
-
Notifications
You must be signed in to change notification settings - Fork 22
Conversion of Imperator Defensive Leagues + compatches for TFE and RoA #2631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
IhateTrains
merged 9 commits into
ParadoxGameConverters:master
from
tanner918:defensive_leagues
Jun 22, 2025
Merged
Conversion of Imperator Defensive Leagues + compatches for TFE and RoA #2631
IhateTrains
merged 9 commits into
ParadoxGameConverters:master
from
tanner918:defensive_leagues
Jun 22, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added part from game_start.txt that forces k_magyar to have the confederation_elective_succession_law.
- Imperator Defensive Leagues now properly convert over to CK3. - At game start, the script will check whether you are using the `Confederations & Leagues` mod, and will setup the Defensive Leagues accordingly. - If you are using the mod, then the script will setup the confederations and leagues as long as there are enough members of eligible title rank, setting them up according to whether the majority of members should use Leagues or Confederations. - If not using the mod, it assumes you are just using the base game confederations, so will only setup confederations using Nomad/Tribal rulers, like in base game. - Setup to have a global variable (`irtock3_enabled`) set to indicate that the IMP-CK3 converter was used, in case any future mod needs to consider that. - Expanded the Welcome event at game start to now have a section that shows off mods that were made to go along with a converted save game. For now, the only mod listed is the `Confederations & Leagues` mod.
- Updated for RoA Version 4.0.0 (mainly just made sure there were no big errors when converting, haven't added much of their new content yet) - RoA changed how it handles the CCU parameter to be similar to how WtWSMS handles it, so the relevant code files were modified to account for that change. - Converter heritage and language files were modified to account for RoA CCU change, as well as change some of the parameters given to some of the heritages/languages by the mods so they make a little more sense. - Merged the Venetic heritage and language file into the main IRToCK3_heritage/language files to simplify things. - Made Basque have Equal Inheritance instead of Visigothic Codes in vanilla CK3 and RoA (TFE and WtWSMS make their own edits) - Renamed zzz_IRToCK3_tfe_override_l_english.yml.liquid to zzz_IRToCK3_mod_override_l_english.yml.liquid and added a section for ROA. - Made Talaiotic map to Nuragic, since they were expected to be closer to them than the Basque. - Added a mapping to ROA's new Nenets culture in the proper out-of-scope region of CK3 - Added a mapping for the romano_hellenic and helleno_roman cultures from the Imperator "Terra Europea - Terra Indomita Sub-Mod" to greek since they represent a kind of Roman-Hellenic hybrid culture in Imperator - Redid the province mappings for RoA since they changed their map a bit. Might need to be reworked later, but should be fine for now. (Since the converter can now convert wasteland provinces to whoever owns most of the land surrounding them, I left quite a bit of the wasteland province mappings the provinceMapper made) - Redid the imperator_invictus mappings, removing the mapped provinces from Subsaharan Africa so they don't all end up Berber/Megalithic.
ISSUES
|
- Moved 00_mongol_invasion_effects.txt edit from the TFE versions of replaceable/removable_file_blocks to vanilla version of files. - Modified become_chakravarti_decision and unite_india_decision_effect so that they can only be taken if e_india has no holder or de jure land, and instead of requiring the three normal Indian Empire titles, it instead requires you to control the entire world_india region (pretty much the same thing as what it required before), and it de jure drifts the kingdoms of all empires that are 80% inside that india region. - Changed title mappings so that BHA maps to e_india instead of MRY. e_india and BHA both represent a united India title/tag in their respective games, so it makes more sense to have those mapped together. - Made HIB map to k_ireland instead of IVE since HIB actually represents a united Ireland. - Updated some of the replaceable/removable_file_blocks for ROA and TFE.
IhateTrains
approved these changes
Jun 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, thanks for all the changes!
Good to see that RoA made their version closer to WtWSMS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES
Finished game_start effect that sets up converted Imperator Defensive Leagues. (Closes Experiment with converting defensive leagues to confederations #2591)
Made a global variable (
irtock3_enabled
) get set at game start that indicates that the converter was used (and you are currently using a converted save game), so that if any mod in the future wants/needs to consider whether you are playing a converted Imperator game, they can easily check that variable.Updated the files for the new TFE update (didn't add anything new aside from just making sure there were no replaceable/removable code errors) (Closes Compatch for TFE's 2025-06-11 update if necessary #2639)
UPDATE (June 20)
Updated for RoA Version 4.0.0 (mainly just made sure there were no big errors when converting, haven't added much of their new content yet)
RoA changed how it handles the CCU parameter to be similar to how WtWSMS handles it, so the relevant code files were modified to account for that change.
Converter heritage and language files were modified to account for RoA CCU change, as well as change some of the parameters given to some of the heritages/languages by the mods so they make a little more sense.
Merged the Venetic heritage and language file into the main IRToCK3_heritage/language files to simplify things.
Made Basque have Equal Inheritance instead of Visigothic Codes in vanilla CK3 and RoA (TFE and WtWSMS make their own edits)
Renamed zzz_IRToCK3_tfe_override_l_english.yml.liquid to zzz_IRToCK3_mod_override_l_english.yml.liquid and added a section for ROA.
Made Talaiotic map to Nuragic, since they were expected to be closer to them than the Basque.
Added a mapping to ROA's new Nenets culture in the proper out-of-scope region of CK3
Added a mapping for the romano_hellenic and helleno_roman cultures from the Imperator "Terra Europea - Terra Indomita Sub-Mod" to greek since they represent a kind of Roman-Hellenic hybrid culture in Imperator
Redid the province mappings for RoA since they changed their map a bit. Might need to be reworked later, but should be fine for now. (Since the converter can now convert wasteland provinces to whoever owns most of the land surrounding them, I left quite a bit of the wasteland province mappings the provinceMapper made)
Redid the imperator_invictus mappings, removing the mapped provinces from Subsaharan Africa so they don't all end up Berber/Megalithic.
UPDATE (June 21)
Moved 00_mongol_invasion_effects.txt edit from the TFE versions of replaceable/removable_file_blocks to vanilla version of files.
Modified become_chakravarti_decision and unite_india_decision_effect so that they can only be taken if e_india has no holder or de jure land, and instead of requiring the three normal Indian Empire titles, it instead requires you to control the entire world_india region (pretty much the same thing as what it required before), and it de jure drifts the kingdoms of all empires that are 80% inside that india region. (Closes The become_chakravarti_decision doesn't work as intended #2596)
Changed title mappings so that BHA maps to e_india instead of MRY. e_india and BHA both represent a united India title/tag in their respective games, so it makes more sense to have those mapped together.
Made HIB map to k_ireland instead of IVE since HIB actually represents a united Ireland.
Updated some of the replaceable/removable_file_blocks for ROA and TFE.