Skip to content

Implement standard constructors for UserErrorException and ConverterException #2098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Implement standard constructors for UserErrorException and ConverterException #2098

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ImperatorToCK3/Exceptions/ConverterException.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
public class ConverterException : Exception {
public ConverterException(string message) : base(message) { }

public ConverterException(string? message, Exception? innerException) : base(message, innerException) {
}
public ConverterException(string? message, Exception? innerException) : base(message, innerException) { }

public ConverterException() : base() { }

Check notice on line 10 in ImperatorToCK3/Exceptions/ConverterException.cs

View check run for this annotation

Codacy Production / Codacy Static Code Analysis

ImperatorToCK3/Exceptions/ConverterException.cs#L10 

Remove this redundant 'base()' call.
}
7 changes: 4 additions & 3 deletions ImperatorToCK3/Exceptions/UserErrorException.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,10 @@

namespace ImperatorToCK3.Exceptions;

class UserErrorException : ConverterException {
internal class UserErrorException : ConverterException {
public UserErrorException(string message) : base(message) { }

public UserErrorException(string? message, Exception? innerException) : base(message, innerException) {
}
public UserErrorException(string? message, Exception? innerException) : base(message, innerException) { }

public UserErrorException() : base() { }

Check notice on line 10 in ImperatorToCK3/Exceptions/UserErrorException.cs

View check run for this annotation

Codacy Production / Codacy Static Code Analysis

ImperatorToCK3/Exceptions/UserErrorException.cs#L10 

Remove this redundant 'base()' call.
}
Loading