Skip to content

Remove portrait conversion workaround for pre-hotfix Invictus 1.7 #2022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2024
Merged

Remove portrait conversion workaround for pre-hotfix Invictus 1.7 #2022

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions ImperatorToCK3/Imperator/Characters/PortraitData.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,12 +87,6 @@ public PortraitData(string dnaString, GenesDB genesDB, string ageSexString = "ma
continue;
}

// Temporary fix for broken Invictus DNA strings which don't have a value for the headgear gene.
// TODO: verify if still require for Invictus version higher than the original pre-hotfix 1.7
if (gene.Id == "headgear") {
continue;
}

var geneTemplateByteIndex = geneIndex.Value * 4;
if (decodedDnaStr.Length <= geneTemplateByteIndex + 3) {
Logger.Warn($"DNA string is too short for gene {gene.Id}!");
Expand Down
Loading