Skip to content

fix: Fix bug in createContactInfo.ts #992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

aoki-atsushi
Copy link
Contributor

@aoki-atsushi aoki-atsushi commented Oct 9, 2024

The protocol was set to mailto even though it was a URL.

Description

The contact.url link was a mailto link.
According to OAS specifications, it should be a link to the inquiry form screen

image

https://swagger.io/specification/
image

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate)

After correction
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

The protocol was set to mailto even though it was a URL.
@aoki-atsushi aoki-atsushi marked this pull request as ready for review October 9, 2024 04:29
Copy link

github-actions bot commented Oct 9, 2024

Visit the preview URL for this PR (updated for commit 4e7446a):

https://docusaurus-openapi-36b86--pr992-d3hhkluy.web.app

(expires Fri, 08 Nov 2024 13:16:48 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: bf293780ee827f578864d92193b8c2866acd459f

@sserrata sserrata merged commit 7fe9da2 into PaloAltoNetworks:main Oct 9, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants