Skip to content

render default value as string literal instead of markdown #958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 10, 2024

Conversation

sserrata
Copy link
Member

Description

Addresses #955

Motivation and Context

It seems we missed an edge case where default values of "false" or "[]" failed to guard and/or render as expected. In the case of the latter, "[]" resulted in an empty string.

How Has This Been Tested?

Tested with the OpenAPI spec provided in referenced issue.

Screenshots (if appropriate)

Screenshot 2024-09-10 at 11 00 02 AM

@sserrata sserrata added the bug Something isn't working label Sep 10, 2024
@sserrata sserrata self-assigned this Sep 10, 2024
Copy link

github-actions bot commented Sep 10, 2024

Size Change: +531 B (+0.01%)

Total Size: 8.6 MB

Filename Size Change
demo/build/assets/js/common.********.js 479 kB +531 B (+0.11%)
ℹ️ View Unchanged
Filename Size
demo/.docusaurus/globalData.json 29.4 kB
demo/build/assets/css/styles.********.css 131 kB
demo/build/assets/js/006e727e.********.js 12.5 kB
demo/build/assets/js/04510fe4.********.js 1.75 kB
demo/build/assets/js/05f64ae1.********.js 3.08 kB
demo/build/assets/js/06e5f0f0.********.js 15.4 kB
demo/build/assets/js/081bfb0d.********.js 7.3 kB
demo/build/assets/js/09e07b87.********.js 3.25 kB
demo/build/assets/js/0c78db99.********.js 6.22 kB
demo/build/assets/js/0cfc62ff.********.js 444 B
demo/build/assets/js/0d832478.********.js 20.1 kB
demo/build/assets/js/0e31c608.********.js 363 B
demo/build/assets/js/0fa9def4.********.js 3.85 kB
demo/build/assets/js/12693653.********.js 19.8 kB
demo/build/assets/js/13012432.********.js 6.75 kB
demo/build/assets/js/14492604.********.js 629 B
demo/build/assets/js/14eb3368.********.js 9.15 kB
demo/build/assets/js/1639936b.********.js 5.69 kB
demo/build/assets/js/177e86db.********.js 8.35 kB
demo/build/assets/js/19d4fd48.********.js 4.96 kB
demo/build/assets/js/19d75775.********.js 6.34 kB
demo/build/assets/js/1a4e3797.********.js 86 kB
demo/build/assets/js/1a8cc2a6.********.js 9.92 kB
demo/build/assets/js/1c54f54e.********.js 7.89 kB
demo/build/assets/js/1e6c5cae.********.js 26.8 kB
demo/build/assets/js/1e6ff21d.********.js 8.39 kB
demo/build/assets/js/1f818248.********.js 8.99 kB
demo/build/assets/js/21f042e7.********.js 2.42 kB
demo/build/assets/js/22dd74f7.********.js 56.9 kB
demo/build/assets/js/2bb7a9e5.********.js 15.6 kB
demo/build/assets/js/2c860537.********.js 6.32 kB
demo/build/assets/js/2de14e09.********.js 2.42 kB
demo/build/assets/js/326c3861.********.js 12.7 kB
demo/build/assets/js/3431.********.js 1.32 kB
demo/build/assets/js/3720c009.********.js 1.73 kB
demo/build/assets/js/3946f914.********.js 25.3 kB
demo/build/assets/js/39d00f16.********.js 16 kB
demo/build/assets/js/3ce58061.********.js 3.99 kB
demo/build/assets/js/3d18bc4d.********.js 1.55 kB
demo/build/assets/js/3e0d14e9.********.js 18.7 kB
demo/build/assets/js/3fccde26.********.js 2.65 kB
demo/build/assets/js/40a238b6.********.js 19.8 kB
demo/build/assets/js/41ad23b9.********.js 443 B
demo/build/assets/js/41cd56a1.********.js 8.14 kB
demo/build/assets/js/423cd203.********.js 11.5 kB
demo/build/assets/js/441ad7e9.********.js 369 B
demo/build/assets/js/466ac800.********.js 29.8 kB
demo/build/assets/js/47abaca6.********.js 3.17 kB
demo/build/assets/js/483a5060.********.js 586 B
demo/build/assets/js/4964e910.********.js 17.9 kB
demo/build/assets/js/499b3970.********.js 373 B
demo/build/assets/js/49bd3d39.********.js 13 kB
demo/build/assets/js/4adec5c6.********.js 1.53 kB
demo/build/assets/js/4afa9934.********.js 6.66 kB
demo/build/assets/js/4b891ed6.********.js 9 kB
demo/build/assets/js/4c5e977b.********.js 77.3 kB
demo/build/assets/js/4db2e020.********.js 6.63 kB
demo/build/assets/js/4eaf684e.********.js 7.85 kB
demo/build/assets/js/54ae5c2a.********.js 6.24 kB
demo/build/assets/js/55a6d13f.********.js 12.5 kB
demo/build/assets/js/56717cba.********.js 3.24 kB
demo/build/assets/js/56a33119.********.js 8.11 kB
demo/build/assets/js/57708823.********.js 5.53 kB
demo/build/assets/js/57f1a671.********.js 9.04 kB
demo/build/assets/js/58ff8b1e.********.js 22.7 kB
demo/build/assets/js/597ddc40.********.js 7.67 kB
demo/build/assets/js/59af61a6.********.js 391 B
demo/build/assets/js/5e95c892.********.js 345 B
demo/build/assets/js/5f33cfb8.********.js 11.4 kB
demo/build/assets/js/5fb917be.********.js 2.8 kB
demo/build/assets/js/62b62ccf.********.js 7.95 kB
demo/build/assets/js/63fc267d.********.js 8.54 kB
demo/build/assets/js/6693.********.js 104 B
demo/build/assets/js/66c76a57.********.js 27 kB
demo/build/assets/js/674cd211.********.js 8.49 kB
demo/build/assets/js/682c57d3.********.js 2.42 kB
demo/build/assets/js/68b61ac5.********.js 31.7 kB
demo/build/assets/js/69a61f78.********.js 18.5 kB
demo/build/assets/js/6ad7bd23.********.js 1.56 kB
demo/build/assets/js/6d85557e.********.js 7.96 kB
demo/build/assets/js/703b796f.********.js 6.79 kB
demo/build/assets/js/71612962.********.js 7.69 kB
demo/build/assets/js/73b594ee.********.js 26.8 kB
demo/build/assets/js/73f06468.********.js 5.27 kB
demo/build/assets/js/77264a1a.********.js 25.3 kB
demo/build/assets/js/785615ec.********.js 15.6 kB
demo/build/assets/js/79d7b0d5.********.js 6.13 kB
demo/build/assets/js/7b96997a.********.js 2.39 kB
demo/build/assets/js/7ca3ae45.********.js 13.4 kB
demo/build/assets/js/7ed7dafe.********.js 20 kB
demo/build/assets/js/7ee7d9e7.********.js 1.69 kB
demo/build/assets/js/7f47b856.********.js 14.1 kB
demo/build/assets/js/7f6346b9.********.js 5.71 kB
demo/build/assets/js/83208226.********.js 1.37 kB
demo/build/assets/js/8361.********.js 5.34 MB
demo/build/assets/js/85d3c400.********.js 3.16 kB
demo/build/assets/js/85e11929.********.js 19.9 kB
demo/build/assets/js/85ec4403.********.js 4.7 kB
demo/build/assets/js/86b273b1.********.js 8.16 kB
demo/build/assets/js/86c45737.********.js 22.6 kB
demo/build/assets/js/8961c7a6.********.js 20.1 kB
demo/build/assets/js/8973.********.js 104 B
demo/build/assets/js/8ab9b16e.********.js 7.77 kB
demo/build/assets/js/8d43b879.********.js 5.93 kB
demo/build/assets/js/8d4e78cd.********.js 3.12 kB
demo/build/assets/js/8f441c78.********.js 16.1 kB
demo/build/assets/js/91696e06.********.js 27.1 kB
demo/build/assets/js/93304a97.********.js 5.79 kB
demo/build/assets/js/94589c06.********.js 15.2 kB
demo/build/assets/js/95d88c92.********.js 8.49 kB
demo/build/assets/js/96d3d581.********.js 408 B
demo/build/assets/js/9714.********.js 152 B
demo/build/assets/js/97810f3c.********.js 19.1 kB
demo/build/assets/js/9b5caaf3.********.js 19.7 kB
demo/build/assets/js/9c42c0f3.********.js 25.7 kB
demo/build/assets/js/a06b4842.********.js 5.77 kB
demo/build/assets/js/a106d181.********.js 10.7 kB
demo/build/assets/js/a1205735.********.js 6.35 kB
demo/build/assets/js/a2b8aca8.********.js 8.22 kB
demo/build/assets/js/a40c6d71.********.js 5.79 kB
demo/build/assets/js/a63defdd.********.js 8.27 kB
demo/build/assets/js/a6cd895f.********.js 23.1 kB
demo/build/assets/js/a6f66deb.********.js 4 kB
demo/build/assets/js/a705d98d.********.js 6.48 kB
demo/build/assets/js/a728d93a.********.js 7.81 kB
demo/build/assets/js/a7bd4aaa.********.js 695 B
demo/build/assets/js/a94703ab.********.js 11 kB
demo/build/assets/js/aa2f1ec7.********.js 19 kB
demo/build/assets/js/ab09fd5c.********.js 23.2 kB
demo/build/assets/js/ab6072f2.********.js 18.5 kB
demo/build/assets/js/aba21aa0.********.js 172 B
demo/build/assets/js/ac9f9fec.********.js 9.28 kB
demo/build/assets/js/ae7f40a3.********.js 31.7 kB
demo/build/assets/js/aeac4323.********.js 631 B
demo/build/assets/js/aec2c957.********.js 7.93 kB
demo/build/assets/js/aedd5031.********.js 8.42 kB
demo/build/assets/js/b2a753ec.********.js 7.86 kB
demo/build/assets/js/b4ebd305.********.js 13.4 kB
demo/build/assets/js/b5c059ef.********.js 25.7 kB
demo/build/assets/js/b89b49f4.********.js 6.89 kB
demo/build/assets/js/baebb6c1.********.js 2.77 kB
demo/build/assets/js/bc17b4cf.********.js 8.5 kB
demo/build/assets/js/bdbe39c2.********.js 2.77 kB
demo/build/assets/js/bead4b8e.********.js 3.29 kB
demo/build/assets/js/bf87ce40.********.js 375 B
demo/build/assets/js/c141421f.********.js 172 B
demo/build/assets/js/c51aa9b5.********.js 413 B
demo/build/assets/js/c65697f5.********.js 18.8 kB
demo/build/assets/js/c7a5be9f.********.js 8.1 kB
demo/build/assets/js/c7ded1cb.********.js 3.22 kB
demo/build/assets/js/c80efd64.********.js 13 kB
demo/build/assets/js/cf07762b.********.js 22.7 kB
demo/build/assets/js/d492db52.********.js 2.47 kB
demo/build/assets/js/d63c7029.********.js 3.2 kB
demo/build/assets/js/d64c2530.********.js 6.17 kB
demo/build/assets/js/d805e82c.********.js 2.51 kB
demo/build/assets/js/dc1ed7fc.********.js 8.42 kB
demo/build/assets/js/dd696920.********.js 19.1 kB
demo/build/assets/js/de527494.********.js 7.83 kB
demo/build/assets/js/df203c0f.********.js 8 kB
demo/build/assets/js/e0075694.********.js 3.87 kB
demo/build/assets/js/e015ccf9.********.js 19.7 kB
demo/build/assets/js/e01f8d18.********.js 6.31 kB
demo/build/assets/js/e5e5340c.********.js 2.65 kB
demo/build/assets/js/e5f74b05.********.js 379 B
demo/build/assets/js/e7e42acb.********.js 2.7 kB
demo/build/assets/js/e9647dd2.********.js 3.88 kB
demo/build/assets/js/eae14b71.********.js 24.1 kB
demo/build/assets/js/eaf4471e.********.js 9.89 kB
demo/build/assets/js/ee308fa3.********.js 7.63 kB
demo/build/assets/js/ee9514c0.********.js 2.52 kB
demo/build/assets/js/f212caf7.********.js 20.1 kB
demo/build/assets/js/f283d1c6.********.js 5.35 kB
demo/build/assets/js/f4486b6b.********.js 9.43 kB
demo/build/assets/js/f4538a24.********.js 2.65 kB
demo/build/assets/js/f65290a6.********.js 8.12 kB
demo/build/assets/js/f8409a7e.********.js 35.8 kB
demo/build/assets/js/f84e10c2.********.js 14.5 kB
demo/build/assets/js/fb27f34a.********.js 435 B
demo/build/assets/js/fcd67c8d.********.js 14.4 kB
demo/build/assets/js/fe97f0d1.********.js 15.2 kB
demo/build/assets/js/main.********.js 649 kB
demo/build/assets/js/runtime~main.********.js 12 kB
demo/build/index.html 86.1 kB

compressed-size-action

Copy link

github-actions bot commented Sep 10, 2024

Visit the preview URL for this PR (updated for commit 8323e7d):

https://docusaurus-openapi-36b86--pr958-md56trbv.web.app

(expires Thu, 10 Oct 2024 16:15:11 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: bf293780ee827f578864d92193b8c2866acd459f

@sserrata sserrata merged commit 3dc71cd into main Sep 10, 2024
13 checks passed
@sserrata sserrata deleted the default-values branch September 10, 2024 16:18
@sserrata sserrata added the v4.0.0 v4.0.0 label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v4.0.0 v4.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant