-
Notifications
You must be signed in to change notification settings - Fork 276
render default value as string literal instead of markdown #958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +531 B (+0.01%) Total Size: 8.6 MB
ℹ️ View Unchanged
|
Visit the preview URL for this PR (updated for commit 8323e7d): https://docusaurus-openapi-36b86--pr958-md56trbv.web.app (expires Thu, 10 Oct 2024 16:15:11 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: bf293780ee827f578864d92193b8c2866acd459f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses #955
Motivation and Context
It seems we missed an edge case where default values of "false" or "[]" failed to guard and/or render as expected. In the case of the latter, "[]" resulted in an empty string.
How Has This Been Tested?
Tested with the OpenAPI spec provided in referenced issue.
Screenshots (if appropriate)