Ensure same-level properties and allOf are rendered #904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 858cc80): https://docusaurus-openapi-36b86--pr904-n520evo6.web.app (expires Sun, 01 Sep 2024 18:04:53 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
|
Size Change: 0 B Total Size: 13.5 MB ℹ️ View Unchanged
|
|
Results of test using example spec provided in repro: 
|
|
Hi |
|
FYI, the "Build Size Report" workflow is failing due to the order in which the action cleans up the initial build, which leaves behind orphaned MDX files. Will ignore for now until a more permanent solution can be found. |
sserrata
added a commit
that referenced
this pull request
Aug 6, 2024
* process properties before allOf to ensure rendering * update tests * remove delete schema lines added for testing * add additional allOf test cases * add tests to documentation * hide allOf discriminator example * fix linter issues * define global tags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses #902 and proposed fix in #903. The root cause appeared to stem from the order in which same-level properties and allOf were being evaluated which led to the properties being ignored.
I added a small test to cover this case with plans to add coverage for additional variations in a later PR.