Skip to content

feat: support const for OAS 3.1.1 #1143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025
Merged

Conversation

markrzen
Copy link
Contributor

@markrzen markrzen commented May 7, 2025

Description

Support const as described in OAS 3.1.1.

Resolves: #1142

Motivation and Context

const allows you to declare a constant value.

It also helps compose annotated enumerations, as an improvement to the original enum.

REL: https://swagger.io/specification/#annotated-enumerations

How Has This Been Tested?

I added a test schema (as seen in PR), and I ran it locally. I did not see any unit/integration test patterns in the repository.

Screenshots (if appropriate)

Screenshot 2025-05-06 at 8 53 35 PM

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@markrzen markrzen marked this pull request as ready for review May 7, 2025 00:55
Copy link

github-actions bot commented May 8, 2025

Visit the preview URL for this PR (updated for commit 9361774):

https://docusaurus-openapi-36b86--pr1143-odq0fqbd.web.app

(expires Sat, 07 Jun 2025 23:28:29 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: bf293780ee827f578864d92193b8c2866acd459f

@markrzen
Copy link
Contributor Author

markrzen commented May 9, 2025

The preview looks good to me.

@markrzen
Copy link
Contributor Author

markrzen commented May 9, 2025

@sserrata As the last contributor to the repository, what is the expectation I should have for review?

@sserrata
Copy link
Member

sserrata commented May 9, 2025

LGTM, thanks for the contribution!

@sserrata sserrata merged commit 6168043 into PaloAltoNetworks:main May 9, 2025
10 checks passed
@markrzen
Copy link
Contributor Author

markrzen commented May 9, 2025

@sserrata Thanks so much. Sorry for the explicit poke. Didn't see any expectation or recommendation in the CONTRIBUTING.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

const values are not displayed
2 participants