fix: handle discriminator subschemas that only inherit via allOf without own properties #1133
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses an issue where the OpenAPI spec defines a discriminator with a subschema that only inherits all fields from the parent (using allOf) and does not define any new properties. Previously, this pattern would cause a runtime error in the Docusaurus OpenAPI plugin due to an attempt to access properties of an undefined object.
See #1132 for more background.
Motivation and Context
OpenAPI allows for discriminator mappings where a child schema inherits all properties from its parent via allOf and does not introduce any new properties. This is a valid and common pattern for modeling inheritance. Prior to this fix, such schemas would cause the documentation build or runtime to fail with a TypeError. This PR adds a safeguard to ensure the code handles these cases gracefully, allowing the documentation to render correctly for all valid OpenAPI discriminator patterns.
How Has This Been Tested?
demo/examples/tests/discriminator.yaml
under/discriminator-empty-subschema
that uses a parent schema with a discriminator and a child schema that only inherits viaallOf
.