Skip to content

ci: upgrade node version to deploy live and deploy preview #1126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

fernandoseguim
Copy link
Contributor

@fernandoseguim fernandoseguim commented Apr 9, 2025

Description

Updated the Node.js version in the CI workflow from v18.20.7 to v20.0.0 to ensure compatibility with Firebase CLI v14.0.1.

Motivation and Context

The current CI workflow is failing due to a version mismatch between Node.js and the Firebase CLI. Firebase CLI v14.0.1 requires Node.js version >=20.0.0 || >=22.0.0, but our workflow was using Node.js v18.20.7. This update is necessary to resolve deployment failures and ensure proper CI/CD pipeline functionality.

How Has This Been Tested?

  1. Verified that the CI workflow runs successfully using Node.js v20.0.0
  2. Confirmed that Firebase deployment completes without version compatibility errors
  3. Validated that all other CI steps continue to function as expected

Types of Changes

  • Bug fix (non-breaking change that resolves an issue)

Checklist

  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my changes where appropriate
  • All new and existing tests passed

@sserrata
Copy link
Member

sserrata commented Apr 9, 2025

Thanks @fernandoseguim...I went ahead and made the chain on the main branch since we use pull_request_target.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants