Skip to content

Remove unused global selector #1031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Remove unused global selector #1031

merged 1 commit into from
Dec 2, 2024

Conversation

blindaa121
Copy link
Collaborator

Description

This PR consists of removing the global selector and class name selector (.theme-code-block-highlighted-line) defined in Line.scss, as this class name is no longer being used in the project.

Motivation and Context

See #1021 for context.

How Has This Been Tested?

Tested by ensuring styles were not affected for the CodeBlock component and warnings mentioned in #1021 have been cleared.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@blindaa121 blindaa121 closed this Dec 2, 2024
@blindaa121 blindaa121 force-pushed the css-selector-cleanup branch from c363f8b to a3e6681 Compare December 2, 2024 19:38
Copy link

github-actions bot commented Dec 2, 2024

Size Change: -109 B (-0.01%)

Total Size: 2.02 MB

Filename Size Change
demo/build/assets/css/styles.********.css 146 kB -109 B (-0.07%)
ℹ️ View Unchanged
Filename Size
demo/.docusaurus/codeTranslations.json 2 B
demo/.docusaurus/docusaurus.config.mjs 13.9 kB
demo/.docusaurus/globalData.json 38.6 kB
demo/.docusaurus/i18n.json 267 B
demo/.docusaurus/registry.js 56.9 kB
demo/.docusaurus/routes.js 52.6 kB
demo/.docusaurus/routesChunkNames.json 21.8 kB
demo/.docusaurus/site-metadata.json 1.23 kB
demo/build/assets/js/main.********.js 692 kB
demo/build/assets/js/runtime~main.********.js 15.2 kB
demo/build/index.html 90.4 kB
demo/build/petstore/add-pet/index.html 27.4 kB
demo/build/petstore/create-user/index.html 21.5 kB
demo/build/petstore/create-users-with-array-input/index.html 21.5 kB
demo/build/petstore/create-users-with-list-input/index.html 21.5 kB
demo/build/petstore/delete-order/index.html 21.5 kB
demo/build/petstore/delete-pet/index.html 21.6 kB
demo/build/petstore/delete-user/index.html 21.8 kB
demo/build/petstore/find-pets-by-status/index.html 22.3 kB
demo/build/petstore/find-pets-by-tags/index.html 22.9 kB
demo/build/petstore/get-inventory/index.html 20.8 kB
demo/build/petstore/get-order-by-id/index.html 21.8 kB
demo/build/petstore/get-pet-by-id/index.html 22.4 kB
demo/build/petstore/get-user-by-name/index.html 21.9 kB
demo/build/petstore/login-user/index.html 22.4 kB
demo/build/petstore/logout-user/index.html 21.2 kB
demo/build/petstore/new-pet/index.html 21.8 kB
demo/build/petstore/pet/index.html 23.5 kB
demo/build/petstore/place-order/index.html 21 kB
demo/build/petstore/schemas/apiresponse/index.html 22.8 kB
demo/build/petstore/schemas/cat/index.html 36.7 kB
demo/build/petstore/schemas/category/index.html 23.9 kB
demo/build/petstore/schemas/dog/index.html 37.1 kB
demo/build/petstore/schemas/honeybee/index.html 37.2 kB
demo/build/petstore/schemas/id/index.html 20.9 kB
demo/build/petstore/schemas/order/index.html 25 kB
demo/build/petstore/schemas/pet/index.html 36.6 kB
demo/build/petstore/schemas/tag/index.html 22.3 kB
demo/build/petstore/schemas/user/index.html 44.8 kB
demo/build/petstore/store/index.html 21.5 kB
demo/build/petstore/subscribe-to-the-store-events/index.html 27.8 kB
demo/build/petstore/swagger-petstore-yaml/index.html 27.9 kB
demo/build/petstore/update-pet-with-form/index.html 21.7 kB
demo/build/petstore/update-pet/index.html 22.2 kB
demo/build/petstore/update-user/index.html 21.8 kB
demo/build/petstore/upload-file/index.html 21.6 kB
demo/build/petstore/user/index.html 22.4 kB

compressed-size-action

@blindaa121 blindaa121 reopened this Dec 2, 2024
Copy link

github-actions bot commented Dec 2, 2024

Visit the preview URL for this PR (updated for commit 8f7d74c):

https://docusaurus-openapi-36b86--pr1031-y58v5s6x.web.app

(expires Wed, 01 Jan 2025 19:44:32 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: bf293780ee827f578864d92193b8c2866acd459f

@blindaa121 blindaa121 self-assigned this Dec 2, 2024
@blindaa121 blindaa121 requested a review from sserrata December 2, 2024 19:48
@blindaa121 blindaa121 added the v4.0.0 v4.0.0 label Dec 2, 2024
@blindaa121 blindaa121 merged commit 1c39f62 into main Dec 2, 2024
17 checks passed
@sserrata sserrata deleted the css-selector-cleanup branch December 16, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v4.0.0 v4.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants