Skip to content

Conversation

@DrownFish19
Copy link
Contributor

@DrownFish19 DrownFish19 commented Nov 4, 2025

PR types

Bug fixes

PR changes

APIs

Description

修复moe_sharding并行策略下,模型保存因缺少moe rank导致相同文件名覆盖问题

相关PR:
paddlenlp dev:PaddlePaddle/PaddleNLP#11162
paddlenlp fleety0421: PaddlePaddle/PaddleNLP#11155
paddleformers dev: #2846
paddleformers fleety1103: #2847

@paddle-bot
Copy link

paddle-bot bot commented Nov 4, 2025

Thanks for your contribution!

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@e7feb8d). Learn more about missing BASE report.

Files with missing lines Patch % Lines
paddleformers/trainer/training_args.py 0.00% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #2846   +/-   ##
==========================================
  Coverage           ?   28.74%           
==========================================
  Files              ?      343           
  Lines              ?    57156           
  Branches           ?        0           
==========================================
  Hits               ?    16427           
  Misses             ?    40729           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@DesmonDay DesmonDay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DesmonDay DesmonDay merged commit 7472164 into PaddlePaddle:develop Nov 7, 2025
5 checks passed
@DrownFish19 DrownFish19 deleted the dev_20251104_update_moe_model_save branch November 7, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants