[API] `paddle.slogdet` 返回值规范化 #72505

aquagull · 2025-04-26T08:55:35Z

PR Category

User Experience

PR Types

Bug fixes

Description

接口变更说明

paddle.linalg.slogdet 的返回值结构已更新，与 PyTorch、NumPy对齐：

版本	返回值类型	输出结构
旧版	单个 Tensor	形状为 `[2, *]` 的堆叠 Tensor (索引 0: sign, 索引 1: logdet)
新版	元组 (tuple)	`(sign, logdet)` 两个独立 Tensor

参考标准：https://data-apis.org/array-api/latest/extensions/generated/array_api.linalg.slogdet.html#slogdet

不兼容变更说明

必须修改组网代码：新版本并且使用patch后，无法按照原有逻辑fetch到两个tensor。

res = paddle.slogdet(x)  <---- 只能fetch到一个tensor

patch中的add_output适用于新增一个不使用的输出，因为接下来的op fetch的还是原来的那个输出，因此不会影响到program。
slogdet原本就有两个输出，只不过在一个tensor里，因此之前的组网逻辑是fetch一个tensor。
patch后变成了两个tensor输出，但按照之前的组网逻辑，就只能够fetch到一个tensor，所以只能更改组网逻辑。

paddle3.0.0 的program为：

patch后的program为：

cn文档pr：

revise slogdet doc docs#7327

Pcard-75624

paddle-bot · 2025-04-26T08:55:39Z

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

CLAassistant · 2025-04-26T08:55:41Z

All committers have signed the CLA.

paddle/phi/kernels/gpu/slogdeterminant_kernel.cu

paddle/phi/infermeta/unary.cc

fangfangssj · 2025-04-30T13:08:45Z

符号推导部分可以参考这个#66444 ，写一下测试过覆盖率测试
CE-Franework可以使用PaddleTest/framework/api/run_paddle_ci.sh和PaddleTest/inference/python_api_test/parallel_run.sh在本地测试debug

aquagull · 2025-05-01T11:00:54Z

符号推导部分可以参考这个#66444 ，写一下测试过覆盖率测试 CE-Franework可以使用PaddleTest/framework/api/run_paddle_ci.sh和PaddleTest/inference/python_api_test/parallel_run.sh在本地测试debug

单测是有开启符号推导的。

    def test_check_output(self):
        self.check_output(check_pir=True) < --- check_symbol_infer 默认为true

CE-Framework的测试是针对之前的api，所以会出现错误。

fangfangssj · 2025-05-01T11:08:46Z

符号推导部分可以参考这个#66444 ，写一下测试过覆盖率测试 CE-Franework可以使用PaddleTest/framework/api/run_paddle_ci.sh和PaddleTest/inference/python_api_test/parallel_run.sh在本地测试debug

单测是有开启符号推导的。
    def test_check_output(self):
        self.check_output(check_pir=True) < --- check_symbol_infer 默认为true
CE-Framework的测试是针对之前的api，所以会出现错误。

好的好的

paddle/phi/infermeta/unary.cc

paddle/phi/kernels/cpu/slogdeterminant_grad_kernel.cc

paddle/phi/kernels/gpu/slogdeterminant_grad_kernel.cu

paddle-ci-bot · 2025-06-06T03:01:11Z

Sorry to inform you that 6900484's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

python/paddle/tensor/linalg.py

aquagull · 2025-06-23T06:32:01Z

/re-run all-failed

HydrogenSulfate · 2025-06-30T02:54:46Z

/re-run distribute build

codecov-commenter · 2025-07-06T19:59:19Z

Codecov Report

Attention: Patch coverage is 72.22222% with 20 lines in your changes missing coverage. Please review.

Please upload report for BASE (develop@e1842d4). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
python/paddle/tensor/linalg.py	10.00%	9 Missing ⚠️
.../interface/infer_symbolic_shape/unary_infer_sym.cc	0.00%	6 Missing ⚠️
...hi/kernels/impl/slogdeterminant_grad_kernel_impl.h	84.37%	5 Missing ⚠️

❌ Your patch status has failed because the patch coverage (72.22%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@            Coverage Diff             @@
##             develop   #72505   +/-   ##
==========================================
  Coverage           ?   72.22%           
==========================================
  Files              ?        6           
  Lines              ?       72           
  Branches           ?        0           
==========================================
  Hits               ?       52           
  Misses             ?       20           
  Partials           ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

aquagull · 2025-07-09T13:20:26Z

/re-run all-failed

HydrogenSulfate · 2025-07-15T03:33:40Z

@aquagull 麻烦合入一下最新的上游代码吧，好像CINN这个有点问题

zyfncg · 2025-07-17T06:36:12Z

paddle/phi/ops/yaml/op_compat.yaml

@@ -3517,7 +3517,7 @@
  inputs :
    x : Input
  outputs :
-    out : Out
+    {sign: Sign, logdet: Logdet}


Out的命名不能更改了

Out的命名不能更改了

已修改, Sign -> Out

heavengate

LGTM for attr

rename Sign to Out for compatibility

aquagull and others added 15 commits April 16, 2025 16:13

add infermeta

e0d50e0

update code

d84c9d6

update code

9d82610

fix

f2c1fe4

update

fe46071

update

f32850f

fix

8140e54

Merge branch 'PaddlePaddle:develop' into slogdet

287a0ef

update

83196ea

update

657dcc8

fix opinfersymbolicshape

0b26e4b

fix grad

d4f0726

update

01f3597

fix

6dddf9e

fix

c57f89a

paddle-bot bot added the contributor External developers label Apr 26, 2025

aquagull added 4 commits April 26, 2025 17:20

fix

f1ff397

empty

02f75e5

fix

33ddaaa

empty

f27db1f

fangfangssj reviewed Apr 30, 2025

View reviewed changes

paddle/phi/kernels/gpu/slogdeterminant_kernel.cu Outdated Show resolved Hide resolved

paddle/phi/infermeta/unary.cc Outdated Show resolved Hide resolved

fix

ae3c884

fangfangssj reviewed May 6, 2025

View reviewed changes

paddle/phi/infermeta/unary.cc Outdated Show resolved Hide resolved

paddle/phi/kernels/cpu/slogdeterminant_grad_kernel.cc Outdated Show resolved Hide resolved

paddle/phi/kernels/gpu/slogdeterminant_grad_kernel.cu Outdated Show resolved Hide resolved

aquagull added 2 commits May 6, 2025 17:15

update

7bc0fc7

fix

ce9ad8a

This was referenced May 28, 2025

Update test_slogdet.py aquagull/PaddleTest#1

Closed

Update test_slogdet.py PaddlePaddle/PaddleTest#3077

Open

Merge branch 'PaddlePaddle:develop' into slogdet

26ac20e

HydrogenSulfate reviewed Jun 9, 2025

View reviewed changes

python/paddle/tensor/linalg.py Outdated Show resolved Hide resolved

aquagull added 9 commits June 9, 2025 22:38

add patch

61d0b6d

fix doc

14b9c3b

Merge branch 'develop' into slogdet

9f03fee

fix 0-size

894d187

fix test_determinant_op

8dcade8

Merge branch 'PaddlePaddle:develop' into slogdet

adc0689

doc

e427789

doc

3091017

fix

61003ef

aquagull mentioned this pull request Jun 20, 2025

revise slogdet doc PaddlePaddle/docs#7327

Open

aquagull added 2 commits June 23, 2025 18:42

update patch yaml

0a26a26

Merge branch 'PaddlePaddle:develop' into slogdet

76c6e42

aquagull force-pushed the slogdet branch from a81b58b to 76c6e42 Compare June 27, 2025 13:30

Merge branch 'develop' into slogdet

be079c0

code-style

2745c98

Merge branch 'PaddlePaddle:develop' into slogdet

9a2afab

zyfncg reviewed Jul 17, 2025

View reviewed changes

heavengate previously approved these changes Jul 17, 2025

View reviewed changes

Update op_compat.yaml

c83b8d4

rename Sign to Out for compatibility

HydrogenSulfate dismissed heavengate’s stale review via c83b8d4 July 17, 2025 07:25

[API] paddle.slogdet 返回值规范化 #72505

Are you sure you want to change the base?

[API] paddle.slogdet 返回值规范化 #72505

Uh oh!

Conversation

aquagull commented Apr 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Category

PR Types

Description

接口变更说明

不兼容变更说明

Uh oh!

paddle-bot bot commented Apr 26, 2025

Uh oh!

CLAassistant commented Apr 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fangfangssj commented Apr 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aquagull commented May 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fangfangssj commented May 1, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

paddle-ci-bot bot commented Jun 6, 2025

Uh oh!

Uh oh!

aquagull commented Jun 23, 2025

Uh oh!

HydrogenSulfate commented Jun 30, 2025

Uh oh!

codecov-commenter commented Jul 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

aquagull commented Jul 9, 2025

Uh oh!

HydrogenSulfate commented Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zyfncg Jul 17, 2025

Choose a reason for hiding this comment

Uh oh!

HydrogenSulfate Jul 17, 2025

Choose a reason for hiding this comment

Uh oh!

heavengate left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

[API] `paddle.slogdet` 返回值规范化 #72505

[API] `paddle.slogdet` 返回值规范化 #72505

aquagull commented Apr 26, 2025 •

edited

Loading

CLAassistant commented Apr 26, 2025 •

edited

Loading

fangfangssj commented Apr 30, 2025 •

edited

Loading

aquagull commented May 1, 2025 •

edited

Loading

codecov-commenter commented Jul 6, 2025 •

edited

Loading

HydrogenSulfate commented Jul 15, 2025 •

edited

Loading