Skip to content

[Doc] Fix some typo of reduce optimize #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

muyuuuu
Copy link
Contributor

@muyuuuu muyuuuu commented Nov 11, 2024

背景:有 opencl 基础,最近正在学习 cuda,学习了入门知识,知道什么是共享内存,知道什么是线程束。

入门之后需要进阶,github 首页推荐了你的教程。看了一会儿觉得很不错,代码示例很到位,客观评价:需要有一定的编程功底和思考,熟悉 cuda 的编程模型,不懂的地方需要及时查阅文档。催更~

在看你教程的过程中,也在不断的学习。一开始我并不知道什么是 bank,什么是 bank conflict,还额外的查阅了些资料。

  1. 修复一些笔误
  2. 在 unroll 中增加了一些解释,想了很久才想通那个展开哈哈哈,很巧妙
  3. 在 bank conflict 中,感觉前面的描述有点重复,简化了一下,主要是解释下什么是 bank 哈哈哈,防止不懂的概念劝退萌新

悄悄的,感觉文档写的很急,是不是下班写的飞速 😸

Copy link
Collaborator

@AndSonder AndSonder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Work! LGTM
感谢对文档的优化 😀

@AndSonder AndSonder merged commit 9037af5 into PaddleJitLab:develop Nov 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants