added modal for staking #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed on https://add-staking-action.pwn-staking-ui.pages.dev! |
pages/index.vue
Outdated
| @@ -296,6 +308,12 @@ const chainIdToToggleTo = computed(() => getChainIdToToggleTo(chainId.value)) | |||
| const switchChain = () => { | |||
| toggleActiveChain(chainId.value) | |||
| } | |||
|
|
|||
| const createStakeModal = ref() | |||
There was a problem hiding this comment.
question: hmm that's an interesting approach but i'm wondering what is a benefit of doing this instead of just simple store that would hold the global values that we need to also access/set outside of the component itself?
Skanislav
approved these changes
May 15, 2025
components/CreateStakeModal.vue
Outdated
| if (pwnTokenBalance.value === undefined || pwnTokenBalance.value === 0n) { | ||
| return "0"; | ||
| } | ||
| return formatDecimalPoint(formatUnits(pwnTokenBalance.value, 18)); |
There was a problem hiding this comment.
Not sure if decimals amount would even change but would make sense to reference it as a contsant
components/CreateStakeModal.vue
Outdated
Comment on lines
342
to
351
| // Add computed properties for potential voting power | ||
| // const potentialMultiplier = computed(() => { | ||
| // if (!lockUpEpochs.value) return 0 | ||
| // return getMultiplierForLockUpEpochs(lockUpEpochs.value) | ||
| // }) | ||
|
|
||
| // const potentialVotingPower = computed(() => { | ||
| // if (!stakeAmount.value || !lockUpEpochs.value) return '0' | ||
| // return getFormattedVotingPower(stakeAmount.value, potentialMultiplier.value) | ||
| // }) |
There was a problem hiding this comment.
no, this was just unused after i've enabled the linter, removed the uncommented code
utils/useTransactions.ts
Outdated
Comment on lines
80
to
99
| console.log("Starting to send a transaction with following parameters:"); | ||
| console.log(transaction); | ||
| // console.log(`Additional UI parameter passed to sendTransaction: step=${step?.text}, safeAddress=${safeAddress}`) | ||
|
|
||
| const { address: userAddress } = getAccount(wagmiAdapter.wagmiConfig) | ||
| const connectedChainId = getAccount(wagmiAdapter.wagmiConfig).chainId; | ||
| console.log( | ||
| `connectedChainId=${connectedChainId}; transaction.chainId=${transaction.chainId}`, | ||
| ); | ||
|
|
||
| // @ts-expect-error probably some type mismatch between writeContract and simulateContract | ||
| await simulateContract(wagmiAdapter.wagmiConfig, transaction) | ||
| if (connectedChainId !== transaction.chainId) { | ||
| console.log( | ||
| `Switching chain from ${connectedChainId} to ${transaction.chainId}.`, | ||
| ); | ||
| const switchedChain = await switchChain(wagmiAdapter.wagmiConfig, { | ||
| chainId: transaction.chainId!, | ||
| }); | ||
| if (switchedChain.id !== transaction.chainId) { | ||
| throw new Error("User denied switching chains before sending a tx."); | ||
| } | ||
| } |
There was a problem hiding this comment.
Do you plan to keep these console.logs here?
There was a problem hiding this comment.
yes i think it does not hurt anything:)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.notion.so/pwndao/Add-staking-action-to-the-UI-121dc8b817b4806fb2f4fcdc1d23cb6c?pvs=4