Apply translate and rotate to user_defined cameras. #470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mccoyn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
user_defined cameras don't apply transformations to the user defined functions. This makes them more difficult to work with when moving the camera. This commit will apply transformations, if present, after the user defined functions.
You can see some discussion of the issue here. It can be worked around. For rotations, the work around makes the user defined functions much more complicated.
http://news.povray.org/povray.general/thread/%3CXnsA9E3A3F647A49seed7%40news.povray.org%3E/
http://news.povray.org/povray.binaries.images/thread/%3C5cec7461%40news.povray.org%3E/
The patch creates a transform in the camera to store the transformations as they are applied to the camera. When the rays are calculated, the user defined function is applied first, followed by the transform.