fix: build script for macOS development #1491
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the build script to support macOS linker flags and fixes incorrect ordering of chmod options.
- Added a
Darwincase to adjust linker flags (-force_loadand-framework CoreFoundation) for macOS. - Unified output filenames to
libiec61131std.soacross platforms. - Corrected
chmodusage to place-Rbefore the mode specifier.
Comments suppressed due to low confidence (1)
scripts/build.sh:296
- The quoting in this log statement breaks the string around $lib_dir. Use consistent quoting or escape inner quotes, for example:
log "Running : $cc --shared -L$lib_dir \
-Wl,-force_load,$lib_dir/libiec61131std.a ..."
log "Running : $cc --shared -L"$lib_dir" \
| -Wl,-force_load,$lib_dir/libiec61131std.a \ | ||
| -o "$lib_dir/libiec61131std.so" \ | ||
| -lm -framework CoreFoundation" | ||
| $cc --shared -L"$lib_dir" \ |
There was a problem hiding this comment.
The macOS branch invocation is missing the --target="$val" flag that appears in the first block, which could lead to incorrect target linking. Add --target="$val" here to match behavior.
Suggested change
| $cc --shared -L"$lib_dir" \ | |
| $cc --shared -L"$lib_dir" \ | |
| --target="$val" \ |
Copilot uses AI. Check for mistakes.
| --target="$val" | ||
|
|
||
| mv "$lib_dir/out.so" "$lib_dir/libiec61131std.so" | ||
| # Check if we're on macOS and adjust linker flags accordingly |
There was a problem hiding this comment.
[nitpick] The macOS-specific linking logic is duplicated in two sections. Consider extracting this into a helper function or shared snippet to avoid repetition and simplify future maintenance.
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build.sh --litas well asbuild.sh --packageshould now work with this PR on MacOS (ARM)