Skip to content

Added PHP end tag to example in readme #2637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

lukmi15
Copy link

@lukmi15 lukmi15 commented Jul 28, 2024

Is there any reason the example in the readme does not have a PHP end tag? If not, then here's a PR.

@coveralls
Copy link

Coverage Status

coverage: 97.208%. remained the same
when pulling 53c67f9 on lukmi15:master
into 2daa50c on PHPOffice:master.

@sbuerk
Copy link
Contributor

sbuerk commented Jul 28, 2024

Usually end php tag should be omited in pure code files. End tags are only used in mixed markup (html) and php files aka template files to close blogs before switching to files.

Using end tags is discouraged since decades in PHP. Cannot speak for this project, but I would not add it to example snippets.

@lukmi15
Copy link
Author

lukmi15 commented Jul 28, 2024

Learned something new, thanks

@lukmi15 lukmi15 closed this Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants