Skip to content

[BUGFIX] allow to load unclean html without exception #1032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 2, 2019
Merged

[BUGFIX] allow to load unclean html without exception #1032

merged 4 commits into from
Jan 2, 2019

Conversation

kaystrobach
Copy link

fixes #754

@troosan
Copy link
Contributor

troosan commented Nov 8, 2017

This is only supported as of PHP 5.4 so as long as we support 5.3 we cannot include this

@kaystrobach
Copy link
Author

How about making a new version without 5.3 support. EOL has been long ago

@troosan
Copy link
Contributor

troosan commented Nov 9, 2017

indeed, it's planned, will be for the next version, if not 1.0

@troosan troosan added this to the Later milestone Nov 16, 2017
@troosan troosan mentioned this pull request Dec 25, 2017
Closed
@troosan troosan modified the milestones: Later, v0.15.0 Dec 25, 2017
@troosan troosan modified the milestones: v0.15.0, Later Feb 10, 2018
@psyray
Copy link

psyray commented Jun 6, 2018

Hi.

Will this PR merged soon ?

@anotherjames
Copy link

For anyone else interested in this (for example, if PHP 5.3 support is dropped), I've prepared for this with a fork that resolves the merge conflicts at develop...anotherjames:patch-1

@kaystrobach
Copy link
Author

kaystrobach commented Sep 12, 2018 •
edited
Loading

We use composer patching to avoid these kind of problems

@anotherjames
Copy link

@kaystrobach so do I... I must be missing something! :) What do you have in your composer.json to get around it?

@troosan troosan modified the milestones: Later, v0.17.0, v1.0.0 Dec 31, 2018
@troosan troosan changed the base branch from develop to develop_v1.0 January 2, 2019 08:09
kaystrobach
kaystrobach commented Jan 2, 2019
View reviewed changes
Copy link
Author

@kaystrobach kaystrobach left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0005%) to 94.581% when pulling 06a9271 on kaystrobach:patch-1 into 2968370 on PHPOffice:develop_v1.0.

@troosan troosan merged commit 8d92409 into PHPOffice:develop_v1.0 Jan 2, 2019
@Progi1984 Progi1984 modified the milestones: v1.0.0, v0.19.0 Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@kaystrobach @troosan @psyray @anotherjames @coveralls @Progi1984