Don't hard-code newline char (ref #2261)

gsherwood · gsherwood · commit 6bed6658b595 · 2019-01-10T10:51:35.000+11:00
diff --git a/src/Standards/PSR2/Sniffs/Files/EndFileNewlineSniff.php b/src/Standards/PSR2/Sniffs/Files/EndFileNewlineSniff.php
@@ -57,7 +57,7 @@ public function process(File $phpcsFile, $stackPtr)
             $error = 'Expected 1 newline at end of file; 0 found';
             $fix   = $phpcsFile->addFixableError($error, $lastToken, 'NoneFound');
             if ($fix === true) {
-                $phpcsFile->fixer->addContent($lastToken, "\n");
+                $phpcsFile->fixer->addNewline($lastToken);
             }
 
             $phpcsFile->recordMetric($stackPtr, 'Number of newlines at EOF', '0');
@@ -90,7 +90,7 @@ public function process(File $phpcsFile, $stackPtr)
                     $phpcsFile->fixer->replaceToken($i, '');
                 }
 
-                $phpcsFile->fixer->replaceToken($lastToken, "\n");
+                $phpcsFile->fixer->replaceToken($lastToken, $phpcsFile->eolChar);
                 $phpcsFile->fixer->endChangeset();
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,7 @@ public function process(File $phpcsFile, $stackPtr)`
`57`	`57`	`$error = 'Expected 1 newline at end of file; 0 found';`
`58`	`58`	`$fix = $phpcsFile->addFixableError($error, $lastToken, 'NoneFound');`
`59`	`59`	`if ($fix === true) {`
`60`		`- $phpcsFile->fixer->addContent($lastToken, "\n");`
	`60`	`+ $phpcsFile->fixer->addNewline($lastToken);`
`61`	`61`	`}`
`62`	`62`
`63`	`63`	`$phpcsFile->recordMetric($stackPtr, 'Number of newlines at EOF', '0');`
`@@ -90,7 +90,7 @@ public function process(File $phpcsFile, $stackPtr)`
`90`	`90`	`$phpcsFile->fixer->replaceToken($i, '');`
`91`	`91`	`}`
`92`	`92`
`93`		`- $phpcsFile->fixer->replaceToken($lastToken, "\n");`
	`93`	`+ $phpcsFile->fixer->replaceToken($lastToken, $phpcsFile->eolChar);`
`94`	`94`	`$phpcsFile->fixer->endChangeset();`
`95`	`95`	`}`
`96`	`96`	`}`