Skip to content

Commit aa4c0c2

Browse files
committed
Merge branch 'feature/psr2-endfilenewline-add-fixed-file' of https://github.com/jrfnl/PHP_CodeSniffer
2 parents 070d688 + 387984e commit aa4c0c2

8 files changed

+20
-2
lines changed

package.xml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1047,15 +1047,21 @@ http://pear.php.net/dtd/package-2.0.xsd">
10471047
<file baseinstalldir="PHP/CodeSniffer" name="ClosingTagUnitTest.6.inc.fixed" role="test" />
10481048
<file baseinstalldir="PHP/CodeSniffer" name="ClosingTagUnitTest.php" role="test" />
10491049
<file baseinstalldir="PHP/CodeSniffer" name="EndFileNewlineUnitTest.1.inc" role="test" />
1050+
<file baseinstalldir="PHP/CodeSniffer" name="EndFileNewlineUnitTest.1.inc.fixed" role="test" />
10501051
<file baseinstalldir="PHP/CodeSniffer" name="EndFileNewlineUnitTest.2.inc" role="test" />
10511052
<file baseinstalldir="PHP/CodeSniffer" name="EndFileNewlineUnitTest.3.inc" role="test" />
1053+
<file baseinstalldir="PHP/CodeSniffer" name="EndFileNewlineUnitTest.3.inc.fixed" role="test" />
10521054
<file baseinstalldir="PHP/CodeSniffer" name="EndFileNewlineUnitTest.4.inc" role="test" />
10531055
<file baseinstalldir="PHP/CodeSniffer" name="EndFileNewlineUnitTest.5.inc" role="test" />
10541056
<file baseinstalldir="PHP/CodeSniffer" name="EndFileNewlineUnitTest.6.inc" role="test" />
1057+
<file baseinstalldir="PHP/CodeSniffer" name="EndFileNewlineUnitTest.6.inc.fixed" role="test" />
10551058
<file baseinstalldir="PHP/CodeSniffer" name="EndFileNewlineUnitTest.7.inc" role="test" />
1059+
<file baseinstalldir="PHP/CodeSniffer" name="EndFileNewlineUnitTest.7.inc.fixed" role="test" />
10561060
<file baseinstalldir="PHP/CodeSniffer" name="EndFileNewlineUnitTest.8.inc" role="test" />
10571061
<file baseinstalldir="PHP/CodeSniffer" name="EndFileNewlineUnitTest.9.inc" role="test" />
1062+
<file baseinstalldir="PHP/CodeSniffer" name="EndFileNewlineUnitTest.9.inc.fixed" role="test" />
10581063
<file baseinstalldir="PHP/CodeSniffer" name="EndFileNewlineUnitTest.10.inc" role="test" />
1064+
<file baseinstalldir="PHP/CodeSniffer" name="EndFileNewlineUnitTest.10.inc.fixed" role="test" />
10591065
<file baseinstalldir="PHP/CodeSniffer" name="EndFileNewlineUnitTest.php" role="test" />
10601066
</dir>
10611067
<dir name="Methods">

src/Standards/PSR2/Sniffs/Files/EndFileNewlineSniff.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ public function process(File $phpcsFile, $stackPtr)
5757
$error = 'Expected 1 newline at end of file; 0 found';
5858
$fix = $phpcsFile->addFixableError($error, $lastToken, 'NoneFound');
5959
if ($fix === true) {
60-
$phpcsFile->fixer->addNewline($lastToken);
60+
$phpcsFile->fixer->addContent($lastToken, "\n");
6161
}
6262

6363
$phpcsFile->recordMetric($stackPtr, 'Number of newlines at EOF', '0');
@@ -90,7 +90,7 @@ public function process(File $phpcsFile, $stackPtr)
9090
$phpcsFile->fixer->replaceToken($i, '');
9191
}
9292

93-
$phpcsFile->fixer->replaceToken($lastToken, $phpcsFile->eolChar);
93+
$phpcsFile->fixer->replaceToken($lastToken, "\n");
9494
$phpcsFile->fixer->endChangeset();
9595
}
9696
}
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
<?php
2+
echo 'foo';
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
<?php
2+
/** Why me?
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
<?php
2+
echo 'foo';
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
<?php
2+
echo 'foo';
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
<?php
2+
echo 'foo';
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
<?php
2+
/** Why me?

0 commit comments

Comments
 (0)