ERA-10960: Profiles - Non-admin users can't switch to their own profiles if they lack proper permissions #1303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctly instead of depending on Axios interceptor
chrisj-er
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes issue when switching to a user profile when the master user isn't an admin. We were getting a 404 when requesting the user profile through
/user/{profile_id}because we weren't setting theUser-Profileheader. Why the issue doesn't happen with admins is beyond my knowledge, maybe related to their permissions.Relevant link(s)
Any background context you want to provide(if applicable)
When the user switches to a profile, we store the profile data in our Redux store. Then, we read that data and add an Axios interceptor that injects the
User-Profileheader on every request that is not/user/me. However, probably due to a race condition or simply because of the order in which things happen, we are not setting that header to the/user/{profile_id}call we do onfetchCurrentUser, which results in the backend returning a 404.The solution in this PR simply consists in injecting the header during the request of the profile, instead of depending on the Axios interceptor.