Skip to content

chore:add ecoscope downloader link to web UI #1297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 27, 2025
Merged

Conversation

JoshuaVulcan
Copy link
Collaborator

What does this PR do?

  • Adds a link

How does it look

  • N/A

Relevant link(s)

@JoshuaVulcan JoshuaVulcan requested a review from Copilot May 19, 2025 21:40
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds an Ecoscope Downloader link to the web UI by bumping translation versions, inserting a new button in the GlobalMenuDrawer, and providing translations in all supported locales.

  • Bumped translation backend version from v1.12 to v1.13 in i18n.js
  • Added placeholder button for Ecoscope Downloader in GlobalMenuDrawer
  • Inserted ecoscopeDownloaderLink translations in each locale file

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/i18n.js Update backendOptions versions to v1.13
src/GlobalMenuDrawer/index.js Insert new button element for Ecoscope Downloader
public/locales/sw/menu-drawer.json Add Swahili translation for ecoscopeDownloaderLink
public/locales/pt/menu-drawer.json Add Portuguese translation for ecoscopeDownloaderLink
public/locales/ne-NP/menu-drawer.json Add Nepali translation for ecoscopeDownloaderLink
public/locales/fr/menu-drawer.json Add French translation for ecoscopeDownloaderLink
public/locales/es/menu-drawer.json Add Spanish translation for ecoscopeDownloaderLink
public/locales/en-US/menu-drawer.json Add English translation for ecoscopeDownloaderLink
Comments suppressed due to low confidence (1)

src/GlobalMenuDrawer/index.js:272

  • [nitpick] Consider adding a unit or integration test to cover the new Ecoscope Downloader button and ensure the ecoscopeDownloaderLink translation key is rendered correctly.
<button></button>

@JoshuaVulcan
Copy link
Collaborator Author

Screenshot 2025-05-19 at 2 57 43 PM

@PADAS PADAS deleted a comment from Copilot AI May 19, 2025
Copy link
Contributor

@luixlive luixlive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you created an env to test this. It's ok since it's very simple, but from your screenshot I feel like the icon is too big, and I'm not sure if it's me but I see it misaligned with the text 🤔

@JoshuaVulcan JoshuaVulcan merged commit 7b0aae0 into develop May 27, 2025
3 checks passed
@JoshuaVulcan JoshuaVulcan deleted the ERA-11323 branch May 27, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants