-
Notifications
You must be signed in to change notification settings - Fork 0
chore:add ecoscope downloader link to web UI #1297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds an Ecoscope Downloader link to the web UI by bumping translation versions, inserting a new button in the GlobalMenuDrawer, and providing translations in all supported locales.
- Bumped translation backend version from v1.12 to v1.13 in i18n.js
- Added placeholder button for Ecoscope Downloader in GlobalMenuDrawer
- Inserted
ecoscopeDownloaderLink
translations in each locale file
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
src/i18n.js | Update backendOptions versions to v1.13 |
src/GlobalMenuDrawer/index.js | Insert new button element for Ecoscope Downloader |
public/locales/sw/menu-drawer.json | Add Swahili translation for ecoscopeDownloaderLink |
public/locales/pt/menu-drawer.json | Add Portuguese translation for ecoscopeDownloaderLink |
public/locales/ne-NP/menu-drawer.json | Add Nepali translation for ecoscopeDownloaderLink |
public/locales/fr/menu-drawer.json | Add French translation for ecoscopeDownloaderLink |
public/locales/es/menu-drawer.json | Add Spanish translation for ecoscopeDownloaderLink |
public/locales/en-US/menu-drawer.json | Add English translation for ecoscopeDownloaderLink |
Comments suppressed due to low confidence (1)
src/GlobalMenuDrawer/index.js:272
- [nitpick] Consider adding a unit or integration test to cover the new Ecoscope Downloader button and ensure the
ecoscopeDownloaderLink
translation key is rendered correctly.
<button></button>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you created an env to test this. It's ok since it's very simple, but from your screenshot I feel like the icon is too big, and I'm not sure if it's me but I see it misaligned with the text 🤔
What does this PR do?
How does it look
Relevant link(s)