ERA-11293 [Part 2: Update ejected dependencies] #1279
Conversation
luixlive
temporarily deployed
to
ERA-11293-update-ejected-dependencies
GitHub Actions
Inactive
| @@ -94,8 +93,8 @@ const AddToIncidentModal = ({ id, onAddToExistingIncident, onAddToNewIncident }) | |||
| )} | |||
|
|
|||
| {hasMore | |||
| ? <li className={`${styles.listItem} ${styles.loadMessage}`} key={0}>{t('modalBody.loadingItem')}</li> | |||
| : <li className={`${styles.listItem} ${styles.loadMessage}`} key="no-more-events-to-load"> | |||
| ? <li key={0}>{t('modalBody.loadingItem')}</li> | |||
There was a problem hiding this comment.
Not sure what is happening here, but from this file and some of the following ones, the className prop was removed, Were those unused?
There was a problem hiding this comment.
The new version of SASS throws a warning when setting a class that doesn't exist in the styles.module.scss file. And we had a few! In this PR i removed them 👍
Weird 🤔 yeah I can't log either. Let me try re-deploying the backend. |
|
@gaboDev I just re-deployed and still we can't log in. I guess there's an issue with the DB or something, it can't be related to the changes here since I'm trying to login directly from the admin and get the same error. What we can do is just do a code review in this one and jump stright to the next PR in the line and to the testing there. Anyway, if everything works fine there, we are good 👍 |
What does this PR do?
Update the dependencies that were exposed after ejecting Create React App, with the exception of dependencies involving the upgrade to React 19, Jest 29 and React Testing Library 16.
Relevant link(s)
Where / how to start reviewing (optional)
All the changes are directly related to the update of the dependencies. Some of them had breaking changes, so certain parts of the code required to be modified. Also, the updates of certain libraries resulted in new warnings being thrown so I cleaned all the faulty code.
Any background context you want to provide(if applicable)
This is the second sequential PR to move away from CRA and Webpack. All we are doing is updating all the libraries to be ready to migrate to the newest versions of React and Jest.