Skip to content

ERA-11293 [Part 1: Eject CRA] #1278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2025
Merged

ERA-11293 [Part 1: Eject CRA] #1278

merged 2 commits into from
Apr 22, 2025

Conversation

luixlive
Copy link
Contributor

@luixlive luixlive commented Apr 8, 2025

What does this PR do?

Eject Create React App: https://create-react-app.dev/docs/available-scripts/#npm-run-eject

The app should work exactly as before, it's just that now we ejected Create React App and we have control over the configurations and dependencies.

Relevant link(s)

Where / how to start reviewing (optional)

None of the changes you'll see in the diff were made manually. They are the result of running the ejection script.

Any background context you want to provide(if applicable)

This is just the first of many PRs to move away of CRA. Our final goal is to move away from the dying Webpack ecosystem and migrate to the newer and faster Vite. But first we need to update all our dependencies and configurations. I will do that as part of ERA-11293, but I'll send several sequential PRs as baby-steps towards the end.

@luixlive luixlive added the deploy label Apr 8, 2025
@luixlive luixlive marked this pull request as draft April 8, 2025 23:04
@luixlive luixlive temporarily deployed to ERA-11293-eject-CRA April 8, 2025 23:04 — with GitHub Actions Inactive
@luixlive luixlive marked this pull request as ready for review April 8, 2025 23:15
@luixlive luixlive requested review from gaboDev and JoshuaVulcan April 8, 2025 23:15
Copy link
Collaborator

@JoshuaVulcan JoshuaVulcan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Way smaller/cleaner than I expected! Looks good and runs fine for me locally.

It would be great to change the names of theconfig and scripts directories to something more specific, and/or to reorganize them somewhere clearer. Look at how they blend into the project structure without communicating what they are and what they're for.

Screenshot 2025-04-08 at 9 13 32 PM

@luixlive
Copy link
Contributor Author

luixlive commented Apr 9, 2025

It would be great to change the names of theconfig and scripts directories to something more specific, and/or to reorganize them somewhere clearer.

@JoshuaVulcan any recommendations? Maybe I've got used to it but I feel like config is explicit about being project configuration. The scripts folder I would suggest renaming react-scripts so it's very obvious what we are talking about there.

@luixlive luixlive changed the base branch from develop to ERA-11293 April 9, 2025 16:28
@luixlive
Copy link
Contributor Author

luixlive commented Apr 9, 2025

Done @JoshuaVulcan

@luixlive luixlive merged commit 10c029f into ERA-11293 Apr 22, 2025
3 checks passed
@luixlive luixlive deleted the ERA-11293-eject-CRA branch April 22, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants