ERA-10349: Support EFB schemas in ER > Location Field [3] #1268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luixlive
commented
Mar 31, 2025
| @@ -147,20 +148,21 @@ const SideBar = () => { | |||
| } | |||
| }, [sidebarOpen, currentTab, socket, isReportDetailsViewActive]); | |||
|
|
|||
| // NOTE: This is getting unmaintainable. Is it really a good practice to use escape like a navigation key? | |||
There was a problem hiding this comment.
This feature has been causing many issues since we added it. This useEffect adds a key down listener in the SideBar to navigate back if Escape is pressed. I wonder if it's worth it to keep adding patches everytime we find a new unwanted side effect this is adding. Pressing Escape to navigate is not common. I know that key is used to close views, and given our navigation is related to a SideBar it kind of makes sense to expect the side bar to close when pressing it. But our SideBar is not just a presentational element to close, its tabs and its items are connected to the router, causing the mentioned side effects like the one I'm fixing it when pressing escape while picking a location in the map.
JoshuaVulcan
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix bug when pressing escape while choosing location