ERA-11250 Swap in new cookie manager by Osana #1241
+17
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: Osana cookie manager
luixlive
reviewed
Mar 7, 2025
| @@ -53,7 +53,11 @@ const UserMenu = ({ onLogOutClick, onProfileClick, selectedUserProfile, user, us | |||
| <Dropdown.Divider /> | |||
| </>} | |||
|
|
|||
| <Dropdown.Item onClick={() => cookieSettingsRef.current.click()}>{t('cookieSettingsItem')}</Dropdown.Item> | |||
There was a problem hiding this comment.
Seems like we can do a bit more cleanup in this file. The following lines can go away:
// Line 1 (just the useRef import)
import React, { useRef } from 'react';
...
// Line 17
const cookieSettingsRef = useRef();
...
// Line 28
<button className="ot-sdk-show-settings" hidden id="ot-sdk-btn" ref={cookieSettingsRef} />
| @@ -62,9 +62,12 @@ const RootApp = () => { | |||
| const { i18n } = useTranslation(); | |||
|
|
|||
| useEffect(() => { | |||
| if (window?.OneTrust) { | |||
| if (typeof window !== 'undefined' && window.Osano) { | |||
There was a problem hiding this comment.
We usually go for optional chaining, so we can keep the code as it was, just changing the property:
if (window?.Osano) {
It's logically the same.
There was a problem hiding this comment.
^^that. window?.Osano?.cm is a step safer as well, since it checks for the target object receiving a property in this code.
JoshuaVulcan
reviewed
Mar 7, 2025
| @@ -53,7 +53,11 @@ const UserMenu = ({ onLogOutClick, onProfileClick, selectedUserProfile, user, us | |||
| <Dropdown.Divider /> | |||
| </>} | |||
|
|
|||
| <Dropdown.Item onClick={() => cookieSettingsRef.current.click()}>{t('cookieSettingsItem')}</Dropdown.Item> | |||
| {window.Osano?.cm && ( | |||
There was a problem hiding this comment.
Let's add some optional chaining to the window object (like window?.Osano?.cm) so we're not set up for future failures in headless test environments.
JoshuaVulcan
approved these changes
Mar 7, 2025
|
Before merging this ticket, please consider the impact this could have on GDPR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Swapping out OneTrust with Osana
feat: Osana cookie manager
How does it look
Relevant link(s)