Skip to content

ERA-10484: Support EFB schemas in ER > Sections and Layout #1195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Dec 2, 2024
Merged

Conversation

luixlive
Copy link
Contributor

@luixlive luixlive commented Nov 26, 2024

What does this PR do?

Add sections rendering in the new SchemaForm component.
This PR also adds the method makeFieldsFromSchema to construct a flat fields object from the schema to easily access the details of each field that needs to be rendered.

How does it look

image

Relevant link(s)

Where / how to start reviewing (optional)

Note: why so many files changed? Changing the pattern to now use the fields object required to change most of the files related to the new SchemaForm pattern. Also, some of the design requirements to achieve sections as Tiffany envisioned them required to do changes in our quicklinks, which also required changes in the detail views for patrols and reports. Most of these changes are simple.

Copy link

swarmia bot commented Nov 26, 2024

@luixlive
Copy link
Contributor Author

@fonzy911 @AlanCalvillo let me know if you would like me to add some other schemas for you to test different rendering of sections 👍

Base automatically changed from ERA-10348 to develop November 28, 2024 17:03
@luixlive luixlive merged commit 6397773 into develop Dec 2, 2024
3 checks passed
@luixlive luixlive deleted the ERA-10484 branch December 2, 2024 22:13
@tiffanynwong
Copy link
Collaborator

Hi! This is looking great!! I have a few questions and comments:

  1. What is the "selected schema: Sections" text?
Screen Shot 2024-12-04 at 8 57 50 AM
  1. Can we remove that text and reduce the space between the meta data section(reported by, priority, etc) and the first section so it equals the same space between all sections?
Screen Shot 2024-12-04 at 11 28 45 AM

@tiffanynwong
Copy link
Collaborator

  1. Section Label spacing: Just a few spacing improvements to make things easier to read
  • Change stroke weight under the section label to 1px instead of 2px
  • There should be more space between the top of the section label and the top of the section. Maybe add 16px top margin?
  • There's a lot of space between the section label and the fields, maybe reduce bottom margin to 8px?
Screen Shot 2024-12-04 at 3 21 26 PM

Just realized this is a PR for the validations, so sorry if these comments don't apply. The validations look sooooo good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants