-
Notifications
You must be signed in to change notification settings - Fork 0
ERA-10484: Support EFB schemas in ER > Sections and Layout #1195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Linked to Story ERA-10484 · Support EFB schemas in ER > Sections and Layout |
@fonzy911 @AlanCalvillo let me know if you would like me to add some other schemas for you to test different rendering of sections 👍 |
gaboDev
approved these changes
Nov 27, 2024
AlanCalvillo
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add sections rendering in the new SchemaForm component.
This PR also adds the method
makeFieldsFromSchema
to construct a flat fields object from the schema to easily access the details of each field that needs to be rendered.How does it look
Relevant link(s)
Where / how to start reviewing (optional)
fields
object can be found in src/ReportManager/DetailsSection/SchemaForm/index.js.Note: why so many files changed? Changing the pattern to now use the fields object required to change most of the files related to the new SchemaForm pattern. Also, some of the design requirements to achieve sections as Tiffany envisioned them required to do changes in our quicklinks, which also required changes in the detail views for patrols and reports. Most of these changes are simple.