ERA-10348: Support EFB schemas in ER > Text Field #1192

gaboDev · 2024-11-19T15:58:59Z

What does this PR do?

Adds support for Text types
Adds feature flag logic
Adds Schema selector under settings pane

How does it look

Form with a schema with short and text type fields

Schema selector

Relevant link(s)

Tracking tickets: ERA-10348
Hosted demo environments

swarmia · 2024-11-19T15:59:04Z

✅ Linked to ERA-10348 · Support EFB schemas in ER > Text Field
➡️ Part of Story ERA-9720 · Support EFB schemas in das-web-react form rendering
➡️ Part of Epic ERA-8048 · Event Type Form Builder (EFB)

luixlive

I like the approach. Provided a few suggestions. However, the opinion that matters the most here is from QA since they will be the ones taking advantage of this. Let's provide them with a way to test this and see what they have to say.
cc: @AlanCalvillo @fonzy911

src/constants/index.js

src/ReportManager/DetailsSection/index.js

src/ReportManager/SchemaForm/SchemaSelector/index.js

src/ReportManager/SchemaForm/index.js

luixlive · 2024-11-21T15:31:08Z

I just noticed I didn't before 😅 The field to select the schema is exactly over the view where QA should be testing the correct rendering of the form:

I don't think that's a good idea, we want them to be able to see how the full event view will show to the user. We should put that field somewhere else, maybe in the settings tab?

gaboDev · 2024-11-21T16:55:22Z

I just noticed I didn't before 😅 The field to select the schema is exactly over the view where QA should be testing the correct rendering of the form

I don't think that's a good idea, we want them to be able to see how the full event view will show to the user. We should put that field somewhere else, maybe in the settings tab?

Sure I agree, but not sure what you refer by settings tab 😅

…s, fixin unit et

luixlive · 2024-11-22T21:56:47Z

Before reviewing, I see some conflicting files 👀

luixlive

This works great. I added just a couple suggestions and I see a couple differences between your components and the designs that I think should be very easy to fix.
Figma:

Env:

1- There should be some space between the input and the description text.
2- Font size of the description should be 14px (in rems).
3- The long text input border should be a lighter gray.
4- Also in the long text input I think we should add some padding to the content in all directions (the text seems too close to the borders).

This should be ready once we fix these things ✅

luixlive · 2024-11-25T15:36:59Z

.env

@@ -13,3 +13,4 @@ REACT_APP_DEFAULT_PATROL_FILTER_FROM_DAYS=1
 # Feature flags
 REACT_APP_LEGACY_RT_ENABLED=false
 REACT_APP_I18N_ENABLED=true
+REACT_APP_EFB_FORM_SCHEMA_SUPPORT_ENABLED=true


This should be false by default. We don't want this to show up in prod envs. Developers must turn it on locally when working on this epic.

I left this as true to facilitate QA process, before this PR get merge I will update it

luixlive · 2024-11-25T15:37:59Z

src/ReportManager/DetailsSection/SchemaForm/fields/Text/index.js

+  REQUIRED: 'required'
+};
+
+export const TextFieldValidators = {


Remember we won't be using these validators, we should remove this and any related code.

luixlive · 2024-11-25T15:38:55Z

src/ReportManager/DetailsSection/SchemaForm/fields/Text/index.js

+  const TextInput = TEXT_INPUT_TYPE_TO_INPUT[textFieldDetails.inputType];
+  const { onFieldChange } = useContext(SchemaFormContext);
+
+  const stylesTheme = {


This variable doesn't have any dependency on the content of the component. We should declare it as a constant outside of the component so it's not attached to its lifecycle and its not redefined in every render 👍

luixlive · 2024-11-25T15:42:46Z

src/ducks/schema-selector.js

+  return state;
+};
+
+export default globallyResettableReducer(schemaSelectorReducer, INITIAL_SCHEMA_SELECTOR_STATE);


I think it would be a good idea to persist this reducer with redux-persist so we don't have to choose the schema everytime we reload the page.

luixlive · 2024-11-25T15:43:32Z

src/reducers/index.js

@@ -124,6 +125,7 @@ const rootReducer = combineReducers({
    userLocation: userLocationReducer,
    userLocationAccessGranted: userLocationAccessGrantedReducer,
    showReportHeatmap: reportHeatmapStateReducer,
+    schemaSelector: schemaSelectorReducer,


A couple TODOs here and in the duck file would be good to remember to delete the reducer after we are done.

luixlive · 2024-11-25T15:53:05Z

@tiffanynwong you may want to test this!

gaboDev · 2024-11-25T16:41:51Z

Forgot to add a clarification for QA folks: This PR is only for rendering feature, form validation and submission are not part of this ticket 👀

luixlive

Looks great! Approved. Still I think it would be great to have thumbs up from @tiffanynwong if that doesn't block us from delivering in time.

A recommendation I have is to change the fixture you added for one that has more fields with more combinations (required / not required, default input, placeholder, long / short field, etc...). You don't need to worry about activated / hidden fields, that is handled by the method I'll add in the next PR makeFieldsFromSchema to remove the hidden fields there!

No required for this PR, but I don't think the persistence of the schema selector is working properly 🤔

…schema at form level

Gabriel López added 3 commits November 11, 2024 19:48

WIP: Text field support

5e67a53

Solve merge conflicts

e57400c

WIP: Adding feature flag, Adding schema selector

62bd4b0

luixlive reviewed Nov 19, 2024

View reviewed changes

Gabriel López added 3 commits November 21, 2024 16:00

PR feedback, WIP: connect SchemaSelector to store

51d955b

Connection Schema selector to store and implemented it in PaneSetting…

ae8e664

…s, fixin unit et

Adding unit test for SchemaForm - Tex

059b0b7

gaboDev changed the title ~~ERA-10348: Support EFB schemas in ER > Field~~ ERA-10348: Support EFB schemas in ER > Text Field Nov 22, 2024

gaboDev added the deploy label Nov 22, 2024

gaboDev requested review from luixlive, AlanCalvillo, JoshuaVulcan and fonzy911 November 22, 2024 21:48

gaboDev marked this pull request as ready for review November 22, 2024 21:49

Merge branch 'develop' into ERA-10348

be8e254

gaboDev temporarily deployed to ERA-10348 November 22, 2024 22:15 — with GitHub Actions Inactive

gaboDev temporarily deployed to padas-app November 22, 2024 22:15 — with GitHub Actions Inactive

luixlive requested changes Nov 25, 2024

View reviewed changes

luixlive requested a review from tiffanynwong November 25, 2024 15:53

Adding PR feedback

90d5625

gaboDev temporarily deployed to ERA-10348 November 25, 2024 17:42 — with GitHub Actions Inactive

gaboDev temporarily deployed to padas-app November 25, 2024 17:43 — with GitHub Actions Inactive

gaboDev requested a review from luixlive November 25, 2024 17:44

luixlive approved these changes Nov 25, 2024

View reviewed changes

Adding a more testable mocked schema

1b3421c

gaboDev temporarily deployed to ERA-10348 November 25, 2024 21:54 — with GitHub Actions Inactive

gaboDev temporarily deployed to padas-app November 25, 2024 21:54 — with GitHub Actions Inactive

Adding extra schema for QA testing

95b4e8f

gaboDev temporarily deployed to ERA-10348 November 25, 2024 22:00 — with GitHub Actions Inactive

gaboDev temporarily deployed to padas-app November 25, 2024 22:01 — with GitHub Actions Inactive

Fixing text field label margin

0b870b4

gaboDev temporarily deployed to ERA-10348 November 25, 2024 22:03 — with GitHub Actions Inactive

gaboDev temporarily deployed to padas-app November 25, 2024 22:04 — with GitHub Actions Inactive

Fixing persistence of schema selector, adding label to show selected …

0d5365f

…schema at form level

gaboDev temporarily deployed to ERA-10348 November 26, 2024 05:09 — with GitHub Actions Inactive

gaboDev had a problem deploying to padas-app November 26, 2024 05:09 — with GitHub Actions Failure

Removing unused code

608735f

gaboDev deployed to ERA-10348 November 26, 2024 17:06 — with GitHub Actions View deployment

gaboDev temporarily deployed to padas-app November 26, 2024 17:06 — with GitHub Actions Inactive

fonzy911 approved these changes Nov 27, 2024

View reviewed changes

gaboDev merged commit 9f754e9 into develop Nov 28, 2024
3 checks passed

gaboDev deleted the ERA-10348 branch November 28, 2024 17:03

ERA-10348: Support EFB schemas in ER > Text Field #1192

ERA-10348: Support EFB schemas in ER > Text Field #1192

Uh oh!

Conversation

gaboDev commented Nov 19, 2024 • edited by jira bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

How does it look

Relevant link(s)

Uh oh!

swarmia bot commented Nov 19, 2024

Uh oh!

luixlive left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

luixlive commented Nov 21, 2024

Uh oh!

gaboDev commented Nov 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

luixlive commented Nov 22, 2024

Uh oh!

luixlive left a comment

Choose a reason for hiding this comment

Uh oh!

luixlive Nov 25, 2024

Choose a reason for hiding this comment

Uh oh!

gaboDev Nov 25, 2024

Choose a reason for hiding this comment

Uh oh!

luixlive Nov 25, 2024

Choose a reason for hiding this comment

Uh oh!

gaboDev Nov 25, 2024

Choose a reason for hiding this comment

Uh oh!

luixlive Nov 25, 2024

Choose a reason for hiding this comment

Uh oh!

luixlive Nov 25, 2024

Choose a reason for hiding this comment

Uh oh!

luixlive Nov 25, 2024

Choose a reason for hiding this comment

Uh oh!

luixlive commented Nov 25, 2024

Uh oh!

gaboDev commented Nov 25, 2024

Uh oh!

luixlive left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

gaboDev commented Nov 19, 2024 •

edited by jira bot

Loading

gaboDev commented Nov 21, 2024 •

edited

Loading