[ERA-9830] wiring up new back-end permissions for data export functionality #1141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaVulcan
requested review from
tarkin88,
AlanCalvillo,
luixlive,
gaboDev,
chrisj-er and
fonzy911
luixlive
approved these changes
Jul 22, 2024
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| ], [dailyReportEnabled, eventFilter, eventTypes, kmlExportEnabled, t]); | ||
| const modals = useMemo(() => { | ||
| const modals = [ |
| } | ||
|
|
||
| return modals; | ||
| /* eslint-disable-next-line react-hooks/exhaustive-deps */ |
There was a problem hiding this comment.
Is there a reason for this eslint-disable?
There was a problem hiding this comment.
Yes -- I'm preserving this from the old code actually. There's a bit of a break in the paradigm of store-driven state changes here, so we pass eventFilter in the dependency array to ensure the value returned by calcEventFilterForRequest always matches the current state of the event filter.
tarkin88
approved these changes
Jul 24, 2024
AlanCalvillo
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
How does it look
Relevant link(s)
Where / how to start reviewing (optional)
Any background context you want to provide(if applicable)