[UPGRADE+DEBUG] Enterprise hardening, README file tree automation #8
Conversation
… resilience fixes
Justadudeinspace
added
bug
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| async def _poll_agents() -> None: | ||
| info = common.detect_agent() | ||
| factory: Callable[[], object] | None = _AGENT_MAP.get(info.name) | ||
| agent = factory() if factory else None | ||
| while True: | ||
| if agent and hasattr(agent, "collect"): | ||
| telemetry.record_event( | ||
| "daemon.poll", | ||
| actor="daemon", | ||
| payload=getattr(agent, "collect")(), | ||
| ) | ||
| await asyncio.sleep(30) |
There was a problem hiding this comment.
The agent poller runs getattr(agent, "collect")() inside the loop without any error handling. If collect() raises (e.g., reading system metrics fails or an agent implementation misbehaves) the exception will bubble out of _poll_agents, cancelling the background task and permanently stopping telemetry collection while the daemon keeps running. Wrapping each iteration in a try/except and logging a degrade would keep the poller alive and matches the stated goal of hardening asynchronous execution paths.
Useful? React with 👍 / 👎.
…ocs=theirs, pyproject=union)
1 participant
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68f8f583407c832a8919b895683045e9