[mkfw] Fix gcc compiler errors #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix gcc errors: * error: redefinition of ‘i’ * error: ‘for’ loop initial declarations are only allowed in C99 mode * Extract function doing checksum calculation for readability
|
This PR does more than is claimed. The GCC error fix should be its own patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #7.
Fix gcc errors:
Extract function doing checksum calculation for readability
I tested this by successfully creating a
.fwfile for doom-odroid-go and running it on my ODROID-GO hardware. For that I followed the instructions mentioned in this release.