-
Notifications
You must be signed in to change notification settings - Fork 85
[Ethereum][Base] Bridge Helper Module with CCIP support #2550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shahthepro
wants to merge
3
commits into
master
Choose a base branch
from
shah/base-bridge-module
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,280
−119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2550 +/- ##
==========================================
- Coverage 41.18% 37.58% -3.60%
==========================================
Files 106 109 +3
Lines 4956 5039 +83
Branches 1302 1326 +24
==========================================
- Hits 2041 1894 -147
- Misses 2913 3143 +230
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
clement-ux
reviewed
Jun 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- All deployed contracts are listed in the deploy PR's description
- BaseBridgeHelperModule
- EthereumBridgeHelperModule
- Deployed contract's verified code (and all dependencies) match the code in master
- EthereumBridgeHelperModule has not been verified.
- Contract constructors have correct arguments
- The transactions that interacted with the newly deployed contract match the deploy script.
- No interactions.
- Governance proposal matches the deploy script
- No governance.
- Smoke tests pass after fork test execution of the governance proposal
Diff contract
BaseBridgeHelperModule
sol2uml diff 0x362DBD4Ff662b2E2b05b9cEDC91da2Dd2c655b26 .,node_modules --apiKey N6EMEJTR6EQHJZSITYSKHUGX6RM6GK6MV3 -n base
(node:4985) ExperimentalWarning: The Fetch API is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
Compared the "BaseBridgeHelperModule" contract with address 0x362DBD4Ff662b2E2b05b9cEDC91da2Dd2c655b26 on base
to local files under folders ".,node_modules"
match @chainlink/contracts-ccip/src/v0.8/ccip/interfaces/IRouterClient.sol
match @chainlink/contracts-ccip/src/v0.8/ccip/libraries/Client.sol
match @openzeppelin/contracts/access/AccessControl.sol
match @openzeppelin/contracts/access/AccessControlEnumerable.sol
match @openzeppelin/contracts/access/IAccessControl.sol
match @openzeppelin/contracts/access/IAccessControlEnumerable.sol
match @openzeppelin/contracts/token/ERC20/extensions/IERC20Metadata.sol
match @openzeppelin/contracts/token/ERC20/IERC20.sol
match @openzeppelin/contracts/token/ERC20/utils/SafeERC20.sol
match @openzeppelin/contracts/utils/Address.sol
match @openzeppelin/contracts/utils/Context.sol
match @openzeppelin/contracts/utils/introspection/ERC165.sol
match @openzeppelin/contracts/utils/introspection/IERC165.sol
match @openzeppelin/contracts/utils/math/SafeCast.sol
match @openzeppelin/contracts/utils/math/SafeMath.sol
match @openzeppelin/contracts/utils/Strings.sol
match @openzeppelin/contracts/utils/structs/EnumerableSet.sol
match contracts/automation/AbstractCCIPBridgeHelperModule.sol
match contracts/automation/AbstractSafeModule.sol
match contracts/automation/BaseBridgeHelperModule.sol
match contracts/governance/Governable.sol
match contracts/interfaces/chainlink/AggregatorV3Interface.sol
match contracts/interfaces/IBasicToken.sol
match contracts/interfaces/IOracle.sol
match contracts/interfaces/ISafe.sol
match contracts/interfaces/IStrategy.sol
match contracts/interfaces/IVault.sol
match contracts/interfaces/IWETH9.sol
match contracts/strategies/BridgedWOETHStrategy.sol
match contracts/token/OUSD.sol
match contracts/utils/Helpers.sol
match contracts/utils/Initializable.sol
match contracts/utils/InitializableAbstractStrategy.sol
match contracts/utils/StableMath.sol
match contracts/vault/VaultStorage.sol
match lib/openzeppelin/interfaces/IERC4626.sol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code changes
Deployment
Governance action (pending)
Code Change Checklist
To be completed before internal review begins:
Internal review:
Deploy checklist
Two reviewers complete the following checklist: