Skip to content

[Ethereum][Base] Bridge Helper Module with CCIP support #2550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

shahthepro
Copy link
Collaborator

Code changes

  • Abstracts away some commonly used functions and modifiers for Safe modules
  • Adds support for CCIP bridging on Base and Ethereum

Deployment

Contract Chain Address
BaseBridgeHelperModule Base 0x362DBD4Ff662b2E2b05b9cEDC91da2Dd2c655b26
EthereumBridgeHelperModule Ethereum 0x630C1763D38AbE76301F58909fa174E7B84A7ECD

Governance action (pending)

  • Enable the new module on Ethereum and disable the old one
  • Enable the new module on Base

Code Change Checklist

To be completed before internal review begins:

  • The contract code is complete
  • Executable deployment file
  • Fork tests that test after the deployment file runs
  • Unit tests *if needed
  • The owner has done a full checklist review of the code + tests

Internal review:

  • Two approvals by internal reviewers

Deploy checklist

Two reviewers complete the following checklist:

- [ ] All deployed contracts are listed in the deploy PR's description
- [ ] Deployed contract's verified code (and all dependencies) match the code in master
- [ ] Contract constructors have correct arguments
- [ ] The transactions that interacted with the newly deployed contract match the deploy script.
- [ ] Governance proposal matches the deploy script
- [ ] Smoke tests pass after fork test execution of the governance proposal

Copy link

github-actions bot commented Jun 24, 2025

Warnings
⚠️ 👀 This PR needs at least 2 reviewers

Generated by 🚫 dangerJS against fc98a11

Copy link

codecov bot commented Jun 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 103 lines in your changes missing coverage. Please review.

Project coverage is 37.58%. Comparing base (d8af1ee) to head (fc98a11).

Files with missing lines Patch % Lines
...ts/contracts/automation/BaseBridgeHelperModule.sol 0.00% 49 Missing ⚠️
...ontracts/automation/EthereumBridgeHelperModule.sol 0.00% 25 Missing ⚠️
...tracts/contracts/automation/AbstractSafeModule.sol 0.00% 17 Missing ⚠️
...acts/automation/AbstractCCIPBridgeHelperModule.sol 0.00% 11 Missing ⚠️
...s/contracts/automation/PlumeBridgeHelperModule.sol 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2550      +/-   ##
==========================================
- Coverage   41.18%   37.58%   -3.60%     
==========================================
  Files         106      109       +3     
  Lines        4956     5039      +83     
  Branches     1302     1326      +24     
==========================================
- Hits         2041     1894     -147     
- Misses       2913     3143     +230     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@clement-ux clement-ux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • All deployed contracts are listed in the deploy PR's description
    • BaseBridgeHelperModule
    • EthereumBridgeHelperModule
  • Deployed contract's verified code (and all dependencies) match the code in master
    • EthereumBridgeHelperModule has not been verified.
  • Contract constructors have correct arguments
  • The transactions that interacted with the newly deployed contract match the deploy script.
    • No interactions.
  • Governance proposal matches the deploy script
    • No governance.
  • Smoke tests pass after fork test execution of the governance proposal

Diff contract

BaseBridgeHelperModule

sol2uml diff 0x362DBD4Ff662b2E2b05b9cEDC91da2Dd2c655b26 .,node_modules --apiKey N6EMEJTR6EQHJZSITYSKHUGX6RM6GK6MV3 -n base
(node:4985) ExperimentalWarning: The Fetch API is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
Compared the "BaseBridgeHelperModule" contract with address 0x362DBD4Ff662b2E2b05b9cEDC91da2Dd2c655b26 on base
to local files under folders ".,node_modules"

match   @chainlink/contracts-ccip/src/v0.8/ccip/interfaces/IRouterClient.sol
match   @chainlink/contracts-ccip/src/v0.8/ccip/libraries/Client.sol
match   @openzeppelin/contracts/access/AccessControl.sol
match   @openzeppelin/contracts/access/AccessControlEnumerable.sol
match   @openzeppelin/contracts/access/IAccessControl.sol
match   @openzeppelin/contracts/access/IAccessControlEnumerable.sol
match   @openzeppelin/contracts/token/ERC20/extensions/IERC20Metadata.sol
match   @openzeppelin/contracts/token/ERC20/IERC20.sol
match   @openzeppelin/contracts/token/ERC20/utils/SafeERC20.sol
match   @openzeppelin/contracts/utils/Address.sol
match   @openzeppelin/contracts/utils/Context.sol
match   @openzeppelin/contracts/utils/introspection/ERC165.sol
match   @openzeppelin/contracts/utils/introspection/IERC165.sol
match   @openzeppelin/contracts/utils/math/SafeCast.sol
match   @openzeppelin/contracts/utils/math/SafeMath.sol
match   @openzeppelin/contracts/utils/Strings.sol
match   @openzeppelin/contracts/utils/structs/EnumerableSet.sol
match   contracts/automation/AbstractCCIPBridgeHelperModule.sol
match   contracts/automation/AbstractSafeModule.sol
match   contracts/automation/BaseBridgeHelperModule.sol
match   contracts/governance/Governable.sol
match   contracts/interfaces/chainlink/AggregatorV3Interface.sol
match   contracts/interfaces/IBasicToken.sol
match   contracts/interfaces/IOracle.sol
match   contracts/interfaces/ISafe.sol
match   contracts/interfaces/IStrategy.sol
match   contracts/interfaces/IVault.sol
match   contracts/interfaces/IWETH9.sol
match   contracts/strategies/BridgedWOETHStrategy.sol
match   contracts/token/OUSD.sol
match   contracts/utils/Helpers.sol
match   contracts/utils/Initializable.sol
match   contracts/utils/InitializableAbstractStrategy.sol
match   contracts/utils/StableMath.sol
match   contracts/vault/VaultStorage.sol
match   lib/openzeppelin/interfaces/IERC4626.sol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants