Skip to content

N-02 Overly Restrictive Validation #2548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025
+4 −4
Merged

N-02 Overly Restrictive Validation #2548

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions contracts/contracts/strategies/plume/RoosterAMOStrategy.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,8 @@ contract RoosterAMOStrategy is InitializableAbstractStrategy {
uint256 public immutable sqrtPriceAtParity;
/// @notice The tick where the strategy deploys the liquidity to
int32 public constant TICK_NUMBER = -1;
/// @notice Minimum liquidity required to continue with the action
/// e.g. deposit, add liquidity, burn OETH
/// @notice Minimum liquidity that must be exceeded to continue with the action
/// e.g. deposit, add liquidity
uint256 public constant ACTION_THRESHOLD = 1e12;
/// @notice Maverick pool static liquidity bin type
uint8 public constant MAV_STATIC_BIN_KIND = 0;
Expand Down Expand Up @@ -527,8 +527,8 @@ contract RoosterAMOStrategy is InitializableAbstractStrategy {
addParam
);

require(_maxWETH > WETHRequired, "More WETH required than specified");
require(_maxOETH > OETHRequired, "More OETH required than specified");
require(_maxWETH >= WETHRequired, "More WETH required than specified");
require(_maxOETH >= OETHRequired, "More OETH required than specified");

// organize values to be used by manager
addParams[0] = addParam;
Expand Down