Skip to content

[usability] Accelerate Support #936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 53 commits into
base: main
Choose a base branch
from
Open

[usability] Accelerate Support #936

wants to merge 53 commits into from

Conversation

wheresmyhair
Copy link
Collaborator

@wheresmyhair wheresmyhair commented Mar 4, 2025

Description

  1. LMFlow now defaults to using Accelerate (i.e, run scripts using accelerate launch ... finetune.py ...). If you prefer to use deepspeed (deepspeed ... finetune.py ...) or accelerate + deepspeed backend, please install using pip install -e '.[deepspeed]'
  2. Removed/archived some less frequently used docs/scripts/modules.
    • docker
    • scripts/data_preprocess, scripts/speculative_decoding, scripts/tools, scripts/vocab_extension
    • service
    • utils
  3. LISA callback and create_customized_optimizer are separated from finetuner.py
  4. Add unittest for finetuner.py

Known Issues

  1. hf_encoder_decoder_model is disabled temporarily. We will have a comprehensive update for encoder-decoder model later.

Tests

scripts Single GPU Multiple GPUs
run_finetune.sh
run_finetune_with_lora.sh
run_finetune_with_qlora.sh
run_finetune_with_lisa.sh
run_finetune_with_custom_optim.sh

@wheresmyhair wheresmyhair mentioned this pull request Feb 3, 2025
34 tasks
@wheresmyhair wheresmyhair marked this pull request as ready for review March 17, 2025 04:15
Copy link
Contributor

@research4pan research4pan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need beta best before merging into main branch, since this will be a major overhaul and may have some compatibility risks for some users.

I would suggest highlighting and redirecting users to this branch in README first. Also, we can tag the current main branch first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants